Add adjacent comment support to hq BlockView and AttributeView queries#282
Merged
kkozik-amplify merged 2 commits intorelease/8.xfrom Apr 7, 2026
Merged
Add adjacent comment support to hq BlockView and AttributeView queries#282kkozik-amplify merged 2 commits intorelease/8.xfrom
kkozik-amplify merged 2 commits intorelease/8.xfrom
Conversation
…on (#134) NewLineOrCommentRule.serialize() now concatenates all child tokens instead of only reading the first, fixing silently dropped comments in multi-token new_line_or_comment nodes. BinaryOpRule distinguishes its trailing new_line_or_comment (which can absorb body-level comments from the grammar) from expression-internal comments, routing absorbed standalone comments to __comments__ and keeping expression-internal ones in __inline_comments__. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collect leading comments from NewLineOrCommentRule siblings in BodyView and attach them to BlockView/AttributeView via to_dict(with_comments=True). Remove the now-inaccurate --with-comments warning from hq CLI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mluhovyi
approved these changes
Apr 6, 2026
rddimon
approved these changes
Apr 6, 2026
kkozik-amplify
added a commit
that referenced
this pull request
Apr 7, 2026
#282) * Fix comment serialization: multi-token NL_OR_COMMENT and classification (#134) NewLineOrCommentRule.serialize() now concatenates all child tokens instead of only reading the first, fixing silently dropped comments in multi-token new_line_or_comment nodes. BinaryOpRule distinguishes its trailing new_line_or_comment (which can absorb body-level comments from the grammar) from expression-internal comments, routing absorbed standalone comments to __comments__ and keeping expression-internal ones in __inline_comments__. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Add adjacent comment support to hq BlockView and AttributeView queries Collect leading comments from NewLineOrCommentRule siblings in BodyView and attach them to BlockView/AttributeView via to_dict(with_comments=True). Remove the now-inaccurate --with-comments warning from hq CLI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collect leading comments from NewLineOrCommentRule siblings in BodyView and attach them to BlockView/AttributeView via to_dict(with_comments=True). Remove the now-inaccurate --with-comments warning from hq CLI.