Allowing multiple classes on klass.selectYear and klass.selectMonth#852
Open
fernandosavio wants to merge 1 commit intoamsul:masterfrom
Open
Allowing multiple classes on klass.selectYear and klass.selectMonth#852fernandosavio wants to merge 1 commit intoamsul:masterfrom
klass.selectYear and klass.selectMonth#852fernandosavio wants to merge 1 commit intoamsul:masterfrom
Conversation
…lasses `$.trim()` used to maintain IE8+ compatibility.
DanielRuf
suggested changes
Mar 31, 2018
Contributor
DanielRuf
left a comment
DanielRuf
left a comment
There was a problem hiding this comment.
Arrays could be better. So we would still use strings but one class = 1 string and multiple classes = array of strings. Also easier to traverse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing multiple classes on
klass.selectYearandklass.selectMonthoptions.$.trim()used to maintain IE8+ compatibility.