AWS JavaScript SDK V3#162
Conversation
|
@LinusU can you please take a look? There is a lot of interest in a release that supports v3 of the AWS SDK. |
Multer (2.x) doesn't have built-in mime type recognition, the value that code is updated to is the one provided by the client. Generally, depending on a mime type submitted by the client isn't a good idea and could lead to exploits (although detecting it isn't a silver bullet either, and could have similar problems...) Anyhow, I not sure that we should remove that functionality since people might be using it? And if we are, we should update the documentation and remove the Besides that, I would recommend to use Multer 3.x instead which makes this library obsolete... |
I'm having trouble finding Multer 3.x. Can you provide a link please?
|
LinusU
left a comment
LinusU
left a comment
There was a problem hiding this comment.
Left a few comments, could you also please remove the package-lock.json file? Since this is a library for others to consume, that lock file will not be respected when anyone depends on this library and thus we don't want it committed here...
|
Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
|
Thank you for the comments. I reran the unit and integration tests and they pass. Regarding versioning, 2.x.x should be branched so it can continue to be maintained separately right? |
|
Bump |
|
When can we expect merging of PR? |
|
@LinusU is there anything blocking the merge and release? |
|
@LinusU would really appreciate this PR being merged 🙏 |
|
Any status on this? |
Migration Guide: When upgrading to this version, you also need to migrate from version 2 of the AWS JavaScript SDK to version 3. Instead of passing an instance of the old `aws.S3`, use the new `S3Client` class from `@aws-sdk/client-s3`. The minimum required version of Node.js has also been increased to 12.0.0, to align with the AWS JavaScript SDK.
|
I'm really sorry for dropping the ball on this! It's now merged and released as 🚢 3.0.0 / 2022-05-27 |
6 participants
Description
Addresses #146
AWS SDK for JavaScript, v3, a rewrite of the AWS SDK, was announced in December 2020: https://aws.amazon.com/blogs/developer/modular-aws-sdk-for-javascript-is-now-generally-available/. V2 was monolithic whereas V3 introduces separate packages for each service. This upgrades multer-s3 to use v3 of the SDK, importing only the S3 module. This will accompanied by a major version bump to 3.0.0.
Changes
@aws-sdk/lib-storageTesting
npm test