chore(YouTube - Translations): Update Japanese#1552
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Japanese translations in strings.xml, correcting a typo in the shorts player resume setting, adding translations for the new voice-over translation custom action, and updating the bold icons setting summaries. A review comment correctly points out that the off and on summaries for the bold icons setting were incorrectly changed to be identical, which is misleading since the off state should describe bold icons being displayed instead of restored to traditional thickness.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| <string name="revanced_settings_disable_bold_icons_summary_off">ナビゲーションバーや動画下のアクションボタンなどのアイコンを従来の太さに戻します。</string> | ||
| <string name="revanced_settings_disable_bold_icons_summary_on">ナビゲーションバーや動画下のアクションボタンなどのアイコンを従来の太さに戻します。</string> |
There was a problem hiding this comment.
The summaries for the _off and _on states of revanced_settings_disable_bold_icons have been changed to be identical.\n\nWhen the setting is disabled (_off), bold icons are displayed, so displaying the summary "ナビゲーションバーや動画下のアクションボタンなどのアイコンを従来の太さに戻します。" (which describes restoring them to traditional thickness) is incorrect and misleading.\n\nIt is better to keep them distinct so that the _off summary accurately describes the disabled state (e.g., that bold icons are displayed).
| <string name="revanced_settings_disable_bold_icons_summary_off">ナビゲーションバーや動画下のアクションボタンなどのアイコンを従来の太さに戻します。</string> | |
| <string name="revanced_settings_disable_bold_icons_summary_on">ナビゲーションバーや動画下のアクションボタンなどのアイコンを従来の太さに戻します。</string> | |
| <string name="revanced_settings_disable_bold_icons_summary_off">太字のアイコンが表示されます。</string>\n <string name="revanced_settings_disable_bold_icons_summary_on">ナビゲーションバーや動画下のアクションボタンなどのアイコンを従来の太さに戻します。</string> |
|
I fixed a typo. I haven't been able to contribute to translations recently because I've been busy in real life. Sorry about that. |
|
It's okay, no need to be sorry. |
2 participants
No description provided.