Skip to content
This repository was archived by the owner on Aug 27, 2022. It is now read-only.

feature: protect manual via config#212

Merged
andi34 merged 4 commits intodevfrom
v3/feature/protect-manual
Mar 22, 2021
Merged

feature: protect manual via config#212
andi34 merged 4 commits intodevfrom
v3/feature/protect-manual

Conversation

@andi34
Copy link
Copy Markdown
Owner

@andi34 andi34 commented Mar 21, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "x" next to an item)

  • New feature
  • Bugfix

What changes did you make? (Give an overview)

Add an option to protect manual and FAQ.
Fix #206

Also fix code style on manual categories.

Is there anything you'd like reviewers to focus on?

andi34 added 3 commits March 21, 2021 14:35
Change-Id: Ibfc19acfaf1d6b6de98c5e19b3863c2a1e1eebb5
Change-Id: I4ad95ee228a86aa3e1374619aed2bd8541ac7ed3
Change-Id: I4a15e1c4c8004e93889865f0f9fcccfc056e13a6
@andi34 andi34 added this to the 3.0.0 milestone Mar 21, 2021
Change-Id: I68d20ec34892c8ec54db9cedaa14fda94f1cdcfb
Comment thread manual/index.php
break;
};

echo '<div class="form-row">';
Copy link
Copy Markdown
Owner Author

@andi34 andi34 Mar 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why, but seems like it was added not in all cases or the div not closed - so move it down to each case.

@andi34 andi34 requested a review from jacques42 March 21, 2021 13:57
@andi34 andi34 merged commit e8893cb into dev Mar 22, 2021
@andi34 andi34 deleted the v3/feature/protect-manual branch March 22, 2021 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FAQ and Manual Button in Backend behind the Login

1 participant