This repository was archived by the owner on Aug 27, 2022. It is now read-only.
Seriously.js: use color picker to define keyed color, use Seriously.js by default#213
Merged
Seriously.js: use color picker to define keyed color, use Seriously.js by default#213
Conversation
Change-Id: I9dac9ebc10bf3a6044b786d8883091bff1c63174
Change-Id: I3e416c820caee23bf854b04e81e732525ab48f88
andi34
force-pushed
the
v3/feature/seriously-rgb
branch
from
a512a69 to
a8ff77b
Compare
…s by default Change-Id: Ia50fc5776ed8e833991b12e78f3db45e23a34bfa
andi34
force-pushed
the
v3/feature/seriously-rgb
branch
from
a8ff77b to
e1b0d6a
Compare
Collaborator
|
Tested and nicely works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
What changes did you make? (Give an overview)
Use a color picker to define color used on Seriously.js chromakeying.
Split defined color into it's rgb channels.
This not only gives the possibility to adjust the green value, it also gives the possibility to use a different color background (e.g. blue-screen instead of a green-screen).
Is there anything you'd like reviewers to focus on?