Skip to content
This repository was archived by the owner on Aug 27, 2022. It is now read-only.

Collage: Always show image after taken#271

Merged
andi34 merged 3 commits intodevfrom
feature/collage-improvements
Jul 11, 2021
Merged

Collage: Always show image after taken#271
andi34 merged 3 commits intodevfrom
feature/collage-improvements

Conversation

@andi34
Copy link
Copy Markdown
Owner

@andi34 andi34 commented Jul 7, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "x" next to an item)

What changes did you make? (Give an overview)

Always show picture on continuous collage before next picture is taken. Make time adjustable image is visible.

andi34 added 3 commits July 7, 2021 10:47
Change-Id: I32e756f7da1d9779551e8028f7de338091f792b6
Change-Id: Ieb03f34eee64e5a1b35a97dadfb3059ef279cf03
Change-Id: I094a4cae85b08d6c86c06bdb46df9c55369bee3e
Copy link
Copy Markdown
Owner Author

@andi34 andi34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work yet

@andi34 andi34 force-pushed the feature/collage-improvements branch from b7abc80 to 842df45 Compare July 11, 2021 11:09
@andi34 andi34 changed the title Collage improvements Collage: Always show image after taken Jul 11, 2021
@andi34 andi34 merged commit b50f250 into dev Jul 11, 2021
@andi34 andi34 deleted the feature/collage-improvements branch July 11, 2021 11:11
@joschre
Copy link
Copy Markdown

joschre commented Aug 6, 2021

Show the Image between Countdowns in fullscreen. Space arround the taken Image are unnecessary.
It works fine :-)

@andi34
Copy link
Copy Markdown
Owner Author

andi34 commented Aug 8, 2021

No, I won't change that by default. But you can use a own custom theme or make your changes here (2nd solution only might cause trouble on updates): https://github.com/andi34/photobooth/blob/dev/src/sass/classic_style.scss#L170

Below the image there'll be a message "Please wait" in future (somehow I forgot to add).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: collage: always show image after taken

2 participants