This repository was archived by the owner on Aug 27, 2022. It is now read-only.
implement countdown offset to compensate shutter-delay and cheese time#286
Merged
andi34 merged 1 commit intoandi34:devfrom Aug 5, 2021
Merged
implement countdown offset to compensate shutter-delay and cheese time#286andi34 merged 1 commit intoandi34:devfrom
andi34 merged 1 commit intoandi34:devfrom
Conversation
Owner
|
Thanks! I'll take a closer look at it later today. Changes to the language files only need to be done to the english file, all other languages need to be translated at crowdin once submitted ( https://crowdin.com/project/photobooth ). |
b697d46 to
d6643b8
Compare
Author
|
@andi34 Thanks for the information. I reverted the change to the german langauge file. |
andi34
reviewed
Aug 5, 2021
andi34
reviewed
Aug 5, 2021
andi34
reviewed
Aug 5, 2021
d6643b8 to
02a3ca2
Compare
02a3ca2 to
8b1f943
Compare
Author
|
I fixed the issues and rebased onto current dev branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
What changes did you make? (Give an overview)
I noticed, that some users that wanted to take pictures with the photobooth seemed to be confused or misled on the time the picture is taken. They assumed that at the moment the box displays "Cheeeeeese" and the live preview hides the image gets taken. This is probably encouraged by the mirror of the DSLR going down between live view and taking the picture.
A colleague suggested changing the countdown in a way, that it reaches 0 at the approximate time the photo is really taken. I implemented it using an offset that is added to the displayed countdown. It looks like this now
6, 5, 4, 3, Cheeeeeese [1 second] + shutter delay + Autofocus [1-2 seconds]
In my opinion, it is more intuitive this way. I would be glad to hear your opinion.
Is there anything you'd like reviewers to focus on?