Skip to content
This repository was archived by the owner on Aug 27, 2022. It is now read-only.

implement countdown offset to compensate shutter-delay and cheese time#286

Merged
andi34 merged 1 commit intoandi34:devfrom
Metropo:feature/contdown_offset
Aug 5, 2021
Merged

implement countdown offset to compensate shutter-delay and cheese time#286
andi34 merged 1 commit intoandi34:devfrom
Metropo:feature/contdown_offset

Conversation

@Metropo
Copy link
Copy Markdown

@Metropo Metropo commented Aug 3, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "x" next to an item)

  • New feature

What changes did you make? (Give an overview)

I noticed, that some users that wanted to take pictures with the photobooth seemed to be confused or misled on the time the picture is taken. They assumed that at the moment the box displays "Cheeeeeese" and the live preview hides the image gets taken. This is probably encouraged by the mirror of the DSLR going down between live view and taking the picture.
A colleague suggested changing the countdown in a way, that it reaches 0 at the approximate time the photo is really taken. I implemented it using an offset that is added to the displayed countdown. It looks like this now
6, 5, 4, 3, Cheeeeeese [1 second] + shutter delay + Autofocus [1-2 seconds]
In my opinion, it is more intuitive this way. I would be glad to hear your opinion.

Is there anything you'd like reviewers to focus on?

@andi34
Copy link
Copy Markdown
Owner

andi34 commented Aug 3, 2021

Thanks! I'll take a closer look at it later today. Changes to the language files only need to be done to the english file, all other languages need to be translated at crowdin once submitted ( https://crowdin.com/project/photobooth ).

@Metropo Metropo force-pushed the feature/contdown_offset branch from b697d46 to d6643b8 Compare August 3, 2021 13:06
@Metropo
Copy link
Copy Markdown
Author

Metropo commented Aug 3, 2021

@andi34 Thanks for the information. I reverted the change to the german langauge file.

Comment thread resources/lang/en.json
Comment thread resources/lang/en.json Outdated
Comment thread resources/lang/en.json Outdated
@Metropo Metropo force-pushed the feature/contdown_offset branch from d6643b8 to 02a3ca2 Compare August 5, 2021 15:38
@Metropo Metropo force-pushed the feature/contdown_offset branch from 02a3ca2 to 8b1f943 Compare August 5, 2021 19:56
@Metropo
Copy link
Copy Markdown
Author

Metropo commented Aug 5, 2021

I fixed the issues and rebased onto current dev branch.

@andi34 andi34 merged commit 563f257 into andi34:dev Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants