This repository was archived by the owner on Aug 27, 2022. It is now read-only.
feature: optional retry to take a picture on error#366
Merged
Conversation
Change-Id: I830caf18be25c6d51a42318ba4055b7e3afb9a72
andi34
commented
Jan 12, 2022
up-87
approved these changes
Jan 12, 2022
up-87
left a comment
up-87
left a comment
There was a problem hiding this comment.
Looks good to me. Used my lunch break to quickly test it on a photobooth and it works like expected (after I noticed and fixed the fact that I uninstalled gphoto2 in my recent experiments with python-gphoto - but that's my fault :D )
Owner
Author
|
Thanks @up-87 , I am going to make mentioned changes to the api.cheesein the evening to avoid double code |
- avoid making a get request while retrying to take a picture Change-Id: Ie59ec8cfc7687dd3558d7b101e51c94e77130cff
- on retry we only need the cheese message again, save some lines of code Change-Id: I21f89d3e8deb0c649e1793cf86678cc8481e454c
andi34
force-pushed
the
feature/picture-retry
branch
from
b5d2447 to
eae2bbb
Compare
andi34
commented
Jan 12, 2022
Owner
Author
|
Adminpanel: Keep in general section? Move to picture section? |
timeout = countdown Change-Id: Ib5e9714aebfd9081ed043dd71f0983c4ab21ebf7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
What changes did you make? (Give an overview)
Add an option to retry taking a picture on error. This might be useful e.g. if gphoto fails because the fokus was not ready.
Is there anything you'd like reviewers to focus on?
As a next step, the api.cheese function should be revisited to avoid double code.