This repository was archived by the owner on Aug 27, 2022. It is now read-only.
Conversation
andi34
commented
Jan 24, 2022
up-87
approved these changes
Jan 25, 2022
New settings from print: - QR size adjustable - QR offset adjustable - QR position adjustable By default place the QR-Code on the bottom right corner, use an small QR-Code with an small offset of 10px to the edges. Change-Id: I28baec6a6d0903cb47e3bf4145a751510740d3c0
Change-Id: Iefa6f4666eaa337866ea0a6be8b8c96b6bade8eb
andi34
force-pushed
the
feature/qr-options
branch
from
e9d1330 to
c56d4d2
Compare
Lower default used error correction level from H to M. Information: https: //www.qrcode.com/en/about/error_correction.html https: //blog.qrstuff.com/2011/12/14/qr-code-error-correction Change-Id: I4849a340caeb4dfbc5933a90de4585ed8d932961
Change-Id: Iddde9a9258b56cb017ae247d22a65aec5602cc74
andi34
force-pushed
the
feature/qr-options
branch
from
c56d4d2 to
f3baaf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
What changes did you make? (Give an overview)
New settings while printing QR-Code onto the image:
By default place the QR-Code on the bottom right corner, use an small QR-Code with an small offset of 10px to the edges.
Is there anything you'd like reviewers to focus on?