Skip to content
This repository was archived by the owner on Aug 27, 2022. It is now read-only.

README.md add security advice to readme#376

Merged
andi34 merged 2 commits intoandi34:devfrom
up-87:security-note
Jan 30, 2022
Merged

README.md add security advice to readme#376
andi34 merged 2 commits intoandi34:devfrom
up-87:security-note

Conversation

@up-87
Copy link
Copy Markdown

@up-87 up-87 commented Jan 27, 2022

Prerequisites checklist

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • New feature
  • Other, please explain:

What changes did you make? (Give an overview)

Add a note on the danger of running Photobooth in untrusted networks or the internet to README.md

Is there anything you'd like reviewers to focus on?

@andi34
Copy link
Copy Markdown
Owner

andi34 commented Jan 27, 2022

Sounds good. Coule you also add the note to the Installer? Maybe use error to display the warning red colored?
We could also discuss adding the note to the welcome page.

@up-87
Copy link
Copy Markdown
Author

up-87 commented Jan 27, 2022

I had a look at the installer and didn't really find a spot where I'd consider it fitting. I think the welcome page might be the better option and we've more possibilities there, as well.

@andi34
Copy link
Copy Markdown
Owner

andi34 commented Jan 28, 2022

Ok, sounds good. you're adding it too?

@andi34 andi34 merged commit 9d15331 into andi34:dev Jan 30, 2022
@up-87 up-87 deleted the security-note branch April 5, 2022 12:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants