Poor image quality

[rawbertp]

Is your feature request related to a problem? Please describe.
The jpgs in the data folder only are around 600K in size (whereas they should be ~3M). I haven't found any setting that would allow me to set the compression but it appears that during image processing the JPGs are compressed/whatever.

Describe the solution you'd like
Configuration options exist that allow the user to control the image processing behavior, e.g. turn off any compression/allow to keep and use the original images.

Describe alternatives you've considered
n/a

Additional context

pi@raspberrypi:/var/www/html/data/images $ ls -ltrh
total 18M
...
-rw-r--r-- 1 www-data www-data 621K Nov  1 10:08 8136336c55f8ce67d7a679540454a2a8.jpg

[andi34]

Please edit your opening post using the bug or feature template, will be reopened once the opening post is updated.

[andi34]

data/images or data/tmp ?

[rawbertp]

It's about data/images (I updated the original post accordingly). It appears the original JPGs are in the data/tmp folder. However, to me a tmp folder is something rather short-lived?!

[andi34]

tmp folder was introduced to store the original before a filter is applied.

[rawbertp]

Alright, thanks for that. So maybe it could be renamed to original or something like that which would be far less confusing. Only a cosmetic issue, though.

However, as I have not enabled/used any filters, why are the images in images 1/5 the size of the originals? And even when applying filters it would be nice to have an option to set the compression level/quality loss. :)

[andi34]

You can adjust the quality here if needed:
https://github.com/andreknieriem/photobooth/blob/master/api/applyEffects.php#L89

Change from 80 to 100.

[andi34]

Alright, thanks for that. So maybe it could be renamed to original or something like that which would be far less confusing. Only a cosmetic issue, though.

You can adjust the folder name via config/admin panel already.

[rawbertp]

You can adjust the quality here if needed:
https://github.com/andreknieriem/photobooth/blob/master/api/applyEffects.php#L89

Change from 80 to 100.

Thanks for this hint, will do!

You can adjust the folder name via config/admin panel already.

Yeah, you're right! I haven't considered that as tmp to me is not a directory for persistent files. Now I know better...

[rawbertp]

Interestingly, when changing imagejpeg($imageResource, $filename_photo, 80); to imagejpeg($imageResource, $filename_photo, 100); the JPG in images is now twice the size of the original in tmp. How does that make sense again?

www-data@raspberrypi:~/html/data$ find . -name 4f538fab4387de592472991c0c0eb189.jpg -exec ls -lh {} \;
-rw-r--r-- 1 www-data www-data 3.0M Nov  1 10:57 ./tmp/4f538fab4387de592472991c0c0eb189.jpg
-rw-r--r-- 1 www-data www-data 73K Nov  1 10:57 ./keying/4f538fab4387de592472991c0c0eb189.jpg
-rw-r--r-- 1 www-data www-data 18K Nov  1 10:57 ./thumbs/4f538fab4387de592472991c0c0eb189.jpg
-rw-r--r-- 1 www-data www-data 6.4M Nov  1 10:57 ./images/4f538fab4387de592472991c0c0eb189.jpg

[andi34]

GD is used for image processing here. it is creating a new image from the original file which is used by Photobooth. it's not a real 1:1 copy like copy and paste.