Device cam and styling fixes#220
Merged
andreknieriem merged 5 commits intoandreknieriem:masterfrom Feb 28, 2020
Merged
Conversation
Change-Id: I81cf6938932d1cb57bb998417e482ca9150bf38f
Change-Id: I0c4ad347a564500dfc7187ffa07795fd3b205be9
Change-Id: I3127522a7d2b0ad276629cbb278f233da4c6ca08
Change-Id: Ib88cc31fdaeb83d65496b0a2722dbb48a4227391
Change-Id: Ie8ca299f8b5542ecdd98e4086d40719b1c334196
andi34
force-pushed
the
feature/devicecam-fixes
branch
from
c431dd5 to
db23778
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hide video--view on error, else no access to reload button on error page
we can only use the device cam to take pictures if we use preview by device cam, therefore disable take pic by device cam config if preview by device cam is not enabled
we can only take a pic using device cam if we have a preview, abort with an error if there's no preview (e.g. because camera access was denied or because no device cam is abvailable)
also fix button font size on error page and collage