feat(@angular-devkit/build-angular): use sass instead of node-sass#13950
Merged
alexeagle merged 2 commits intoangular:masterfrom Mar 20, 2019
alan-agius4:dart-sass-default
Merged
feat(@angular-devkit/build-angular): use sass instead of node-sass#13950alexeagle merged 2 commits intoangular:masterfrom alan-agius4:dart-sass-default
sass instead of node-sass#13950alexeagle merged 2 commits intoangular:masterfrom
alan-agius4:dart-sass-default
Conversation
Collaborator
Author
|
I have some doubts re the console msg, as we'll have too many console infos when starting the dev server and
|
Collaborator
Author
|
@alexeagle what are your thoughts about the above? So we still do the console msg? |
filipesilva
approved these changes
Mar 20, 2019
Contributor
filipesilva
left a comment
There was a problem hiding this comment.
LGTM but I'd like @clydin to have a look, since he made most of the original changes.
clydin
approved these changes
Mar 20, 2019
BREAKING CHANGE: we no longer use `node-sass` by default, instead we use `sass` (dart-sass). While in most cases this should not have an impact the generated code, dart sass has some differences from Ruby Sass. See https://github.com/sass/dart-sass#behavioral-differences-from-ruby-sass for more details If you wish to use `node-sass` instead of `sass` you need to install node-sass as a dev dependency. npm users ``` npm install node-sass --save-dev ``` yarn users ``` yarn add node-sass --dev ``` **Note:** for larger Sass projects to avoid this performance hit you might want to install `fibers`. See: https://www.npmjs.com/package/fibers Ref: TOOL-748
alexeagle
approved these changes
Mar 20, 2019
14 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: we no longer use
node-sassby default, instead we usesass(dart-sass).While in most cases this should not have an impact the generated code, dart sass has some differences from Ruby Sass. See https://github.com/sass/dart-sass#behavioral-differences-from-ruby-sass for more details
If you wish to use
node-sassinstead ofsassyou need to install node-sass as a dev dependency.npm users
yarn users
Note: for larger Sass projects to avoid this performance hit you might want to install
fibers. See: https://www.npmjs.com/package/fibersRef: TOOL-748