Skip to content

feat(@angular-devkit/build-angular): use sass instead of node-sass#13950

Merged
alexeagle merged 2 commits intoangular:masterfrom
alan-agius4:dart-sass-default
Mar 20, 2019
Merged

feat(@angular-devkit/build-angular): use sass instead of node-sass#13950
alexeagle merged 2 commits intoangular:masterfrom
alan-agius4:dart-sass-default

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 commented Mar 19, 2019

BREAKING CHANGE: we no longer use node-sass by default, instead we use sass (dart-sass).

While in most cases this should not have an impact the generated code, dart sass has some differences from Ruby Sass. See https://github.com/sass/dart-sass#behavioral-differences-from-ruby-sass for more details

If you wish to use node-sass instead of sass you need to install node-sass as a dev dependency.

npm users

npm install node-sass --save-dev

yarn users

yarn add node-sass --dev

Note: for larger Sass projects to avoid this performance hit you might want to install fibers. See: https://www.npmjs.com/package/fibers

Ref: TOOL-748

@alan-agius4
Copy link
Copy Markdown
Collaborator Author

I have some doubts re the console msg, as we'll have too many console infos when starting the dev server and

  1. The more we add the more people will start ignored them
  2. They get invasive as there is no way to turn these off at the moment.

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Mar 19, 2019
@alan-agius4
Copy link
Copy Markdown
Collaborator Author

@alexeagle what are your thoughts about the above? So we still do the console msg?

Copy link
Copy Markdown
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd like @clydin to have a look, since he made most of the original changes.

alan-agius4 and others added 2 commits March 20, 2019 21:30
BREAKING CHANGE: we no longer use `node-sass` by default, instead we use `sass` (dart-sass).

While in most cases this should not have an impact the generated code, dart sass has some differences from Ruby Sass. See https://github.com/sass/dart-sass#behavioral-differences-from-ruby-sass for more details

If you wish to use `node-sass` instead of `sass` you need to install node-sass as a dev dependency.

npm users
```
npm install node-sass --save-dev
```

yarn users
```
yarn add node-sass --dev
```

**Note:** for larger Sass projects to avoid this performance hit you might want to install `fibers`. See: https://www.npmjs.com/package/fibers

Ref: TOOL-748
Copy link
Copy Markdown
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The breaking change message is a good start for helping users get out of a hole. Let's see how it goes during RC

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants