This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngClass): do not break on invalid values#16699
Closed
gkalpak wants to merge 1 commit intoangular:masterfrom
Closed
fix(ngClass): do not break on invalid values#16699gkalpak wants to merge 1 commit intoangular:masterfrom
gkalpak wants to merge 1 commit intoangular:masterfrom
Conversation
Previously, when an `ngClass` expression evaluated to something that was not a string, array or object (and was truthy), an error would be thrown while trying to call `.split()` on a non-string value. This error was not very helpful for the user to identify the root cause of the problem. This commit fixes it by ensuring such values are converted to string. Fixes angular#16697
Member
Author
|
Or maybe it is better to just throw a more informative error instead. |
petebacondarwin
approved these changes
Sep 19, 2018
Contributor
petebacondarwin
left a comment
petebacondarwin
left a comment
There was a problem hiding this comment.
I think this is reasonable.
gkalpak
added a commit
that referenced
this pull request
Sep 20, 2018
Previously, when an `ngClass` expression evaluated to something that was not a string, array or object (and was truthy), an error would be thrown while trying to call `.split()` on a non-string value. This error was not very helpful for the user to identify the root cause of the problem. This commit fixes it by ensuring such values are converted to string. Fixes #16697 Closes #16699
ghost
mentioned this pull request
Contributor
|
This milestone seems to be inaccurate since this went into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.
What is the current behavior? (You can also link to an open issue here)
When an
ngClassexpression evaluates to something that is not a string, array or object (and is truthy), an error will be thrown while trying to call.split()on a non-string value. This error is not very helpful for the user to identify the root cause of the problem.See #16697.
What is the new behavior (if this is a feature change)?
Such values are converted to string.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Fix/Feature: Docs have been added/updatedOther information:
Fixes #16697.