fix(cdk/platform): tolerate composedPath errors during event replay#33390
Open
cyphercodes wants to merge 1 commit into
Open
fix(cdk/platform): tolerate composedPath errors during event replay#33390cyphercodes wants to merge 1 commit into
cyphercodes wants to merge 1 commit into
Conversation
cyphercodes
changed the title
cyphercodes
force-pushed
the
fix-event-target-replay-composed-path
branch
from
32cf11c to
0684c29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Falls back to
event.targetwhen_getEventTargetcannot readevent.composedPath(). Angular hydration event replay can dispatch events whosecomposedPath()throws, and this keeps CDK target resolution from crashing in that path while preserving the composed-path behavior for normal Shadow DOM events.Fixes #33386.
Testing
pnpm install --frozen-lockfilepnpm exec tsc --ignoreConfig --ignoreDeprecations 6.0 --target ES2022 --module commonjs --moduleResolution node --lib DOM,ES2022 --skipLibCheck --outDir /tmp/angular-smoke-out src/cdk/platform/features/shadow-dom.ts tmp-shadow-dom-smoke.tsnode /tmp/angular-smoke-out/tmp-shadow-dom-smoke.jspnpm exec prettier --check src/cdk/platform/features/shadow-dom.tspnpm exec tsc --ignoreConfig --ignoreDeprecations 6.0 --noEmit --target ES2022 --module nodenext --moduleResolution nodenext --lib DOM,ES2022 --skipLibCheck src/cdk/platform/features/shadow-dom.ts tmp-shadow-dom-smoke.tsgit diff --checkNote: the temporary smoke file was used only for local verification and is not committed.