Skip to content

refactor: KotlinCleanup - CustomTabsHelper#12136

Merged
mikehardy merged 1 commit intoankidroid:mainfrom
david-allison:cleanup-CustomTabsHelper
Aug 24, 2022
Merged

refactor: KotlinCleanup - CustomTabsHelper#12136
mikehardy merged 1 commit intoankidroid:mainfrom
david-allison:cleanup-CustomTabsHelper

Conversation

@david-allison
Copy link
Copy Markdown
Member

The !! could not be removed without an error

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

The !! could not be removed without an error
@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Aug 23, 2022
Copy link
Copy Markdown
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mikehardy mikehardy added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Aug 24, 2022
@mikehardy mikehardy merged commit 6608d24 into ankidroid:main Aug 24, 2022
@github-actions github-actions Bot added this to the 2.16 release milestone Aug 24, 2022
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Aug 24, 2022
@david-allison david-allison deleted the cleanup-CustomTabsHelper branch April 7, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants