Skip to content

refactor: make Note Fields non-null#12151

Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:fields-not-null
Aug 24, 2022
Merged

refactor: make Note Fields non-null#12151
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:fields-not-null

Conversation

@david-allison
Copy link
Copy Markdown
Member

Kotlin Cleanup, useful for Kotlin conversion of ParsedNode

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Kotlin Cleanup, useful for Kotlin conversion of ParsedNode
Copy link
Copy Markdown
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Aug 24, 2022
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Aug 24, 2022
@BrayanDSO BrayanDSO merged commit ccc2d55 into ankidroid:main Aug 24, 2022
@github-actions github-actions Bot added this to the 2.16 release milestone Aug 24, 2022
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Aug 24, 2022
@david-allison david-allison deleted the fields-not-null branch April 7, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants