Skip to content

Detect role argument_specs files as a lintable kind#2091

Merged
ssbarnea merged 1 commit intoansible:mainfrom
ziegenberg:fix-1688-add-kind-arg-specs
May 3, 2022
Merged

Detect role argument_specs files as a lintable kind#2091
ssbarnea merged 1 commit intoansible:mainfrom
ziegenberg:fix-1688-add-kind-arg-specs

Conversation

@ziegenberg
Copy link
Copy Markdown
Contributor

@ziegenberg ziegenberg commented May 1, 2022

…based on argument specification

Beginning with Ansible version 2.11 role argument validation based on an argument specification was introduced. This specification is defined in the meta/argument_specs.yml file of a role.

This change enables the linter to detect this new format and for it to be used in future rules.

Fixes: #1688
Relates to: #1966

@ziegenberg ziegenberg requested a review from a team as a code owner May 1, 2022 21:15
@ziegenberg ziegenberg requested review from a team, priyamsahoo, ssbarnea and webknjaz May 1, 2022 21:15
@ziegenberg ziegenberg force-pushed the fix-1688-add-kind-arg-specs branch from 056c847 to f18aee2 Compare May 1, 2022 22:13
…based on argument specification

Beginning with ansible version 2.11 role argument validation based on an
argument specification was introduced. This specification is defined in
the meta/argument_specs.yml file of a role.

This change enables the linter to detect this new format and for it to
be used in future rules.

Fixes: ansible#1688
Relates: ansible#1966

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg ziegenberg force-pushed the fix-1688-add-kind-arg-specs branch from f18aee2 to 91e3016 Compare May 1, 2022 22:19
@ziegenberg ziegenberg changed the title add new default lintable kind arg_specs for role argument validation … Add new default lintable kind arg_specs for role argument validation … May 1, 2022
@ssbarnea ssbarnea added skip-changelog Can be missed from the changelog. bug and removed skip-changelog Can be missed from the changelog. labels May 3, 2022
@ssbarnea ssbarnea changed the title Add new default lintable kind arg_specs for role argument validation … Detect role argument_specs files as a lintable kind May 3, 2022
@ssbarnea ssbarnea merged commit 6ffd7a8 into ansible:main May 3, 2022
@ziegenberg ziegenberg deleted the fix-1688-add-kind-arg-specs branch May 3, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

meta/argument_specs.yml in a role is treated as a playbook

2 participants