Schema fix#3671
Merged
ssbarnea merged 2 commits intoansible:mainfrom Sep 30, 2022
Merged
Conversation
apatard
requested review from
Shaps,
ganeshrn,
shatakshiiii,
sky-joker and
ssbarnea
and removed request for
a team
Commit "Adopt molecule config JSON schema (ansible#3668)" (acb9ae0) has imported the molecule schema into data/ but everything is using src/molecule/schemas/ as directory for the schema. So: - Update src/molecule/data/molecule.json with parts of src/molecule/schemas/molecule.json content with the one. The update/ replacement was partial as the local schema handles in a better way the MoleculeDependencyModel. The new schema was allowing to use the "shell" dependency with an empty command. - Update schema $id to point to the correct location - Fix test link to point to the correct schema file. - Fix path to the schema in schema_v3.py Signed-off-by: Arnaud Patard <apatard@hupstream.com>
With the new schema file, the schema check doesn't return the same error strings, so update them. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
Contributor
|
I believe there is a relationship to PR #3667. |
ssbarnea
approved these changes
Sep 30, 2022
davedittrich
pushed a commit
to davedittrich/molecule
that referenced
this pull request
Oct 24, 2022
* Fix import of molecule schema. Commit "Adopt molecule config JSON schema (ansible#3668)" (acb9ae0) has imported the molecule schema into data/ but everything is using src/molecule/schemas/ as directory for the schema. So: - Update src/molecule/data/molecule.json with parts of src/molecule/schemas/molecule.json content with the one. The update/ replacement was partial as the local schema handles in a better way the MoleculeDependencyModel. The new schema was allowing to use the "shell" dependency with an empty command. - Update schema $id to point to the correct location - Fix test link to point to the correct schema file. - Fix path to the schema in schema_v3.py Signed-off-by: Arnaud Patard <apatard@hupstream.com> * rc/molecule/test/unit/model/v2/test_dependency_section.py: Fix checks With the new schema file, the schema check doesn't return the same error strings, so update them. Signed-off-by: Arnaud Patard <apatard@hupstream.com> Signed-off-by: Arnaud Patard <apatard@hupstream.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit "Adopt molecule config JSON schema (#3668)" (acb9ae0)
has imported the molecule schema into data/ but everything is using
src/molecule/schemas/ as directory for the schema.
So:
from src/molecule/data/. The replacement was partial as the local
schema handles in a better way the MoleculeDependencyModel. The
new schema was allowing to use the "shell" dependency with an
empty command.
Signed-off-by: Arnaud Patard apatard@hupstream.com