chore: Form.Item should not support requiredMark#41725
Merged
zombieJ merged 2 commits intoant-design:masterfrom Apr 10, 2023
Merged
chore: Form.Item should not support requiredMark#41725zombieJ merged 2 commits intoant-design:masterfrom
zombieJ merged 2 commits intoant-design:masterfrom
Conversation
Contributor
|
|
Wxh16144
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #41725 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 614 614
Lines 10503 10503
Branches 2876 2876
=========================================
Hits 10503 10503
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Member
|
解决啥问题，PR 里描述一下？ |
zombieJ
approved these changes
Apr 10, 2023
Member
Author
好的，已补充~ |
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
* test: add case * chore: Form.Item does not support requiredMark
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
* test: add case * chore: Form.Item does not support requiredMark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
Background:
Solution
修改后
<Form.Item />将不支持修改requiredMark属性，只能通过<Form />的requiredMark统一设置。📝 Changelog
Form.Itemaccidentally overwriting requiredMark logic errorForm.Item意外覆盖 requiredMark 逻辑问题☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 8cce78b
Refactor the
requiredMarkprop logic in theFormcomponent and its children. Remove unnecessary props and add test cases and comments to improve the code quality and readability.🔍 Walkthrough
🤖 Generated by Copilot at 8cce78b
requiredMarkprop in theFormandFormItemcomponents (link, link, link)requiredMarkprop from theFormItemPropsinterface incomponents/form/FormItem/index.tsxto avoid passing it to theFormItemcomponent (link)requiredMarkprop from theFormItemLabelcomponent incomponents/form/FormItem/ItemHolder.tsxas it is now passed from theFormcomponent (link)FormItemLabelPropsinterface incomponents/form/FormItemLabel.tsxto explain the internal usage of therequiredMarkprop (link)Formcomponent incomponents/form/__tests__/index.test.tsxto verify that therequiredMarkprop works as expected when theForm.Itemcomponent has norequiredprop (link)requiredMarkprop does not render when it is not needed (link)