feat: Divider Component Token#42627
Merged
MadCcc merged 12 commits intoant-design:featurefrom Aug 11, 2023
Merged
Conversation
Contributor
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #42627 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 663 663
Lines 11273 11274 +1
Branches 3047 3047
=========================================
+ Hits 11273 11274 +1
☔ View full report in Codecov by Sentry. |
51 tasks
Member
|
@hms181231 可以参考这个 pr 添加一个 component token 的 debug demo |
Member
|
CI 挂了，可以本地运行 |
Contributor
Author
|
@MadCcc 大佬空了看看这个 有需要更改的 我这边及时调整 |
Member
|
这边拖了比较久不好意思，我直接收尾了哈，感谢贡献 |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
MadCcc
approved these changes
Aug 11, 2023
This was referenced Sep 7, 2023
This was referenced Sep 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
ref #41884
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 62ec5bf
Refactored the
Dividercomponent to use a new component token for the vertical gutter margin and updated the documentation in both English and Chinese to reflect this change. Deprecated the less variables related to theDividercomponent.🔍 Walkthrough
🤖 Generated by Copilot at 62ec5bf
dividerVerticalGutterMarginproperty toverticalGutterMargininComponentTokeninterface (link)genSharedDividerStylefunction to useverticalGutterMarginproperty instead ofdividerVerticalGutterMarginproperty (link)dividerVerticalGutterMarginproperty fromgenDefaultComponentTokenfunction (link)genDefaultComponentTokenfunction to return a function that takes global token as argument and returns an object withverticalGutterMarginandsizePaddingEdgeHorizontalproperties (link)Dividercomponent in English documentation with new component token and deprecated less variables (docs/react/migrate-less-variables.en-US.md, link)Dividercomponent in Chinese documentation with new component token and deprecated less variables (docs/react/migrate-less-variables.zh-CN.md, link)