Skip to content

type(Button): remove unnecessary code#43439

Merged
li-jia-nan merged 1 commit intoant-design:masterfrom
thinkasany:master
Jul 7, 2023
Merged

type(Button): remove unnecessary code#43439
li-jia-nan merged 1 commit intoant-design:masterfrom
thinkasany:master

Conversation

@thinkasany
Copy link
Copy Markdown
Member

@thinkasany thinkasany commented Jul 7, 2023

🤔 This is a ...

  • TypeScript definition update

💡 Background and solution

export SizeType 已经包含了undefined 类型

image

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at e81baf5

Improve code quality of button-group.tsx component. Fix import order and simplify group size context type.

🔍 Walkthrough

🤖 Generated by Copilot at e81baf5

  • Simplify the type of GroupSizeContext to SizeType (link) in button-group.tsx
  • Adjust the import order of modules in button-group.tsx to follow the ESLint rule import/order (link)

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 7, 2023

@thinkasany thinkasany changed the title type(Button): remove unnecessary code fix: Optimize code style Jul 7, 2023
Comment thread components/modal/ConfirmDialog.tsx Outdated
@thinkasany thinkasany changed the title fix: Optimize code style type(Button): remove unnecessary code Jul 7, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2f0c82f) 100.00% compared to head (e81baf5) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #43439   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          648       648           
  Lines        10968     10968           
  Branches      2978      2978           
=========================================
  Hits         10968     10968           
Impacted Files Coverage Δ
components/button/button-group.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants