fix(stream): handle invalid JSON escape sequences in MessageStream#1007
Open
xodn348 wants to merge 1 commit intoanthropics:mainfrom
Open
fix(stream): handle invalid JSON escape sequences in MessageStream#1007xodn348 wants to merge 1 commit intoanthropics:mainfrom
xodn348 wants to merge 1 commit intoanthropics:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #996
When the Anthropic API streams tool-use deltas containing invalid JSON escape sequences (e.g.
\d,\p,\sfrom regex patterns),partialParse()throws an unhandled error that crashes the entireMessageStream. This is a runtime crash with no way for consumers to recover gracefully.Change
Wrapped the
partialParse(jsonBuf)call in#accumulateMessagewith a try-catch that silently skips the delta on parse failure. The stream continues processing subsequent events, and the final complete JSON (which uses proper\\descaping) parses correctly.Before:
After:
This is the minimal surgical fix — one file changed, 5 lines added, 1 removed.
Verification
tsc --noEmitpasses (EXIT_CODE=0)npm testpasses (641 passed, 5 failed pre-existing Nock connection errors in ToolRunnerE2E unrelated to this change)