fix: add libyaml-dev dependency for apt#11291
Merged
moonming merged 1 commit intoapache:masterfrom Jun 5, 2024
Merged
Conversation
was not installed during make deps on the ubuntu dev container for vscode. since this is definitely required for luarocks to work there shouldnt be any negative consequences on any system that already has it installed
shreemaan-abhishek
approved these changes
May 27, 2024
moonming
approved these changes
Jun 3, 2024
AlinsRan
approved these changes
Jun 4, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
was not installed during make deps on the ubuntu dev container for vscode. since this is definitely required for luarocks to work there shouldnt be any negative consequences on any system that already has it installed
Description
Add a explicit dependency on
libyaml-devin the apt base systems, since it does not get installed on at leastsome distributions (ubuntu 22 dev container in this case). Without this luarocks will not install any dependencies and fails saying it can't find the lib.
No changes to the performance_test.sh (the only test file that is relevant) need to be made
Fixes # (issue)
#11290
Checklist