Skip to content

fix: add libyaml-dev dependency for apt#11291

Merged
moonming merged 1 commit intoapache:masterfrom
adam-huganir:patch-1
Jun 5, 2024
Merged

fix: add libyaml-dev dependency for apt#11291
moonming merged 1 commit intoapache:masterfrom
adam-huganir:patch-1

Conversation

@adam-huganir
Copy link
Copy Markdown
Contributor

was not installed during make deps on the ubuntu dev container for vscode. since this is definitely required for luarocks to work there shouldnt be any negative consequences on any system that already has it installed

Description

Add a explicit dependency on libyaml-dev in the apt base systems, since it does not get installed on at least
some distributions (ubuntu 22 dev container in this case). Without this luarocks will not install any dependencies and fails saying it can't find the lib.

No changes to the performance_test.sh (the only test file that is relevant) need to be made

Fixes # (issue)

#11290

Checklist

  • [x ] I have explained the need for this PR and the problem it solves
  • [x ] I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

was not installed during make deps on the ubuntu dev container for vscode. since this is definitely required for luarocks to work there shouldnt be any negative consequences on any system that already has it installed
@shreemaan-abhishek shreemaan-abhishek changed the title fix: install-dependencies script missing libyaml-dev dependency for apt fix: add libyaml-dev dependency for apt Jun 3, 2024
@moonming moonming requested review from AlinsRan and bzp2010 June 4, 2024 10:20
@moonming moonming merged commit d77d672 into apache:master Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants