fix(brotli): Preserve ETag and Last-Modified headers in Brotli-compressed response#12853
Merged
Baoyuantop merged 5 commits intoapache:masterfrom Apr 13, 2026
Merged
fix(brotli): Preserve ETag and Last-Modified headers in Brotli-compressed response#12853Baoyuantop merged 5 commits intoapache:masterfrom
Baoyuantop merged 5 commits intoapache:masterfrom
Conversation
dosubot
bot
added
size:L
Baoyuantop
reviewed
Jan 4, 2026
5 tasks
Baoyuantop
added
the
wait for update
Baoyuantop
added
awaiting review
and removed
wait for update
Baoyuantop
added
wait for update
Contributor
Author
Contributor
Author
|
any update? |
Baoyuantop
approved these changes
Jan 22, 2026
Baoyuantop
added
awaiting review
and removed
wait for update
Baoyuantop
requested review from
AlinsRan,
membphis,
nic-6443 and
shreemaan-abhishek
moonming
requested changes
Mar 16, 2026
Member
moonming
left a comment
moonming
left a comment
There was a problem hiding this comment.
Hi @yuweizzz, thanks for fixing the Brotli ETag preservation issue (#12707)!
Downgrading strong ETags to weak ETags after compression is the correct behavior per HTTP spec (RFC 7232). With 6 reviews, this looks well-discussed.
To confirm merge readiness:
- Are all review comments addressed?
- Does the fix also handle the Last-Modified header correctly alongside ETag?
- Tests look present — do they cover both strong and weak ETag inputs?
This seems close to ready. Thank you!
Contributor
Author
|
yes, I confirm that all the part your mentioned has fixed now. |
Contributor
Author
|
any update? |
shreemaan-abhishek
approved these changes
Apr 13, 2026
moonming
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Downgrade etag when in needed.
Which issue(s) this PR fixes:
Fixes #12707
Checklist