fix(jwt-auth): enforce algorithm match before signature verification#13182
Open
shreemaan-abhishek wants to merge 4 commits intoapache:masterfrom
Open
fix(jwt-auth): enforce algorithm match before signature verification#13182shreemaan-abhishek wants to merge 4 commits intoapache:masterfrom
shreemaan-abhishek wants to merge 4 commits intoapache:masterfrom
Conversation
Verify that the JWT header's "alg" claim matches the consumer's configured algorithm before performing signature verification, per RFC 8725 Section 2.1. Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
- Add nil guard on jwt.header before accessing alg to prevent potential nil index errors on malformed tokens - Remove untrusted token alg value from log message; only log the expected algorithm - Update test to match revised log message
dosubot
bot
added
size:M
nic-6443
previously approved these changes
Apr 9, 2026
moonming
previously approved these changes
Apr 9, 2026
Baoyuantop
previously approved these changes
Apr 9, 2026
shreemaan-abhishek
dismissed stale reviews from Baoyuantop, moonming, and nic-6443
via
53d4a7f
…lgo-mismatch Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
algclaim matches the consumer's configured algorithm before performing signature verification, per RFC 8725 Section 2.1Test plan
t/plugin/jwt-auth.t): creates an RS256 consumer, submits a token with mismatched algorithm, asserts 401 rejection with correct error logprove -I. -Itest-nginx/lib -r t/plugin/jwt-auth.tpasses