fix(tencent-cloud-cls): add ssl_verify option and fix shared state in cls-sdk#13194
Open
shreemaan-abhishek wants to merge 1 commit intoapache:masterfrom
Open
Conversation
… cls-sdk The cls-sdk used module-level `headers_cache` and `params_cache` tables that were reused across requests. Under concurrent access this could cause headers or params from one request to leak into another. Replace them with per-request local tables. Also add a `ssl_verify` plugin configuration option (default: true) so TLS certificate verification is no longer unconditionally disabled, and restrict `scheme` to its valid values via an enum.
dosubot
bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
headers_cacheandparams_cachetables in cls-sdk with per-request local tables to prevent data leaking between concurrent requests.ssl_verifyplugin configuration option (default:true) so TLS certificate verification is no longer unconditionally disabled.schemeto restrict it tohttpandhttps.Test plan
t/plugin/tencent-cloud-cls.ttests passssl_verifydefaults totrueand is correctly passed through to the HTTP client