feature(core): implement core.sleep#2397
Merged
moonming merged 9 commits intoapache:masterfrom Oct 19, 2020
Merged
Conversation
membphis
reviewed
Oct 12, 2020
Member
membphis
left a comment
There was a problem hiding this comment.
LGTM, except for minor code style
membphis
approved these changes
Oct 13, 2020
Member
|
Is there a long sleep in the project? |
Member
|
This change seems to be of little use to the current code |
Contributor
Author
Among the current code, it really only work better when the worker process being shut down at the time of triggering request limiting and delaying processing. And we can keep it as a better way to sleep for the future usage scenarios. |
Member
|
I think this feature is useful. When the APISIX instance restarts, we need to exit |
spacewander
approved these changes
Oct 19, 2020
Member
|
@dabue many thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2170
Use a small time interval (such as 1s) to complete a relatively long sleep behavior, so that the worker process can be shut down gracefully.