Skip to content

feature: support multiple ports like stream listen in http and https …#2409

Merged
spacewander merged 7 commits intoapache:masterfrom
tzssangglass:IssueNo1195
Oct 17, 2020
Merged

feature: support multiple ports like stream listen in http and https …#2409
spacewander merged 7 commits intoapache:masterfrom
tzssangglass:IssueNo1195

Conversation

@tzssangglass
Copy link
Copy Markdown
Member

@tzssangglass tzssangglass commented Oct 13, 2020

…listen port. (#1195)

fix #1195

What this PR does / why we need it:

The Apache APISIX listens to a single port by default in http and https, this PR support multiple ports listen.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@membphis
Copy link
Copy Markdown
Member

CI output:

+ ./bin/apisix init
lua: ./bin/apisix:887: attempt to call field 'new' (a nil value)
stack traceback:
	./bin/apisix:887: in function '?'
	./bin/apisix:1154: in main chunk
	[C]: ?
Error: Process completed with exit code 1.

@tzssangglass
Copy link
Copy Markdown
Member Author

someone else can approved?

1 similar comment
@tzssangglass
Copy link
Copy Markdown
Member Author

someone else can approved?

@membphis membphis requested review from moonming and nic-chen October 15, 2020 15:00
@nic-chen
Copy link
Copy Markdown
Member

@membphis
Copy link
Copy Markdown
Member

please take a look at the output of CI: https://github.com/apache/apisix/pull/2409/checks?check_run_id=1260519517#step:6:125

Scan detected 6 error(s) in 2 file(s):
Reading configuration file [.travis/ASF-Release.cfg]...
Scanning files starting at [./]...
Scan detected 6 error(s) in 2 file(s):
  [./FAQ.md]:
     279: line has trailing whitespace.
     287: line has trailing whitespace.
     289: line has trailing whitespace.
     298: line has trailing whitespace.
  [./FAQ_CN.md]:
     237: line has trailing whitespace.
     239: line has trailing whitespace.

@tzssangglass
Copy link
Copy Markdown
Member Author

need test case for change.

here is an example:

https://github.com/apache/apisix/blob/master/.travis/apisix_cli_test.sh#L156-L170

ok, thx

@tzssangglass
Copy link
Copy Markdown
Member Author

The last commit was on my company's virtual machine. Maybe it caused the security check to fail. In the evening I will submit from my own computer.

@tzssangglass tzssangglass requested a review from membphis October 16, 2020 08:16
@spacewander spacewander merged commit 90109ca into apache:master Oct 17, 2020
@tzssangglass tzssangglass deleted the IssueNo1195 branch October 17, 2020 13:59
@moonming moonming added this to the 2.0 milestone Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: support multiple ports like stream listen in http and https listen port.

5 participants