feature: support multiple ports like stream listen in http and https …#2409
Merged
spacewander merged 7 commits intoapache:masterfrom Oct 17, 2020
Merged
feature: support multiple ports like stream listen in http and https …#2409spacewander merged 7 commits intoapache:masterfrom
spacewander merged 7 commits intoapache:masterfrom
Conversation
Member
|
CI output: |
membphis
approved these changes
Oct 13, 2020
Member
Author
|
someone else can approved? |
1 similar comment
Member
Author
|
someone else can approved? |
membphis
requested changes
Oct 15, 2020
Member
|
need test case for change. here is an example: |
membphis
reviewed
Oct 16, 2020
Member
|
please take a look at the output of CI: https://github.com/apache/apisix/pull/2409/checks?check_run_id=1260519517#step:6:125 |
2.Fix check https://github.com/apache/apisix/pull/2409/checks?check_run_id=1260519517#step:6:125 3.Adding Test Cases;
Member
Author
ok, thx |
Member
Author
|
The last commit was on my company's virtual machine. Maybe it caused the security check to fail. In the evening I will submit from my own computer. |
added 3 commits
October 16, 2020 14:21
I don't think it's the code that's causing the problem.
membphis
approved these changes
Oct 16, 2020
nic-chen
approved these changes
Oct 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…listen port. (#1195)
fix #1195
What this PR does / why we need it:
The Apache APISIX listens to a single port by default in http and https, this PR support multiple ports listen.
Pre-submission checklist: