Skip to content

change(echo): remove odd auth_value#4055

Merged
Yiyiyimu merged 2 commits intoapache:masterfrom
batman-ezio:doc/issue_3974
May 28, 2021
Merged

change(echo): remove odd auth_value#4055
Yiyiyimu merged 2 commits intoapache:masterfrom
batman-ezio:doc/issue_3974

Conversation

@batman-ezio
Copy link
Copy Markdown
Contributor

@batman-ezio batman-ezio commented Apr 15, 2021

It can be done with key-auth plugin.

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Fix #3974

@batman-ezio batman-ezio changed the title doc: remove auth auth docs: remove auth auth Apr 15, 2021
| body | string | optional | | | Body to replace upstream response. |
| after_body | string | optional | | | Body after the modification of filter phase. |
| headers | object | optional | | | New headers for response |
| auth_value | string | optional | | | Auth value |
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove it from the source & test too.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@batman-ezio batman-ezio changed the title docs: remove auth auth docs: remove auth value Apr 15, 2021
@spacewander spacewander changed the title docs: remove auth value change(echo): remove odd auth_value Apr 15, 2021
@tokers
Copy link
Copy Markdown
Contributor

tokers commented Apr 15, 2021

@batman-ezio The CI is still failed.

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@Yiyiyimu Yiyiyimu merged commit 1266801 into apache:master May 28, 2021
tao12345666333 added a commit to tao12345666333/ingress-controller that referenced this pull request Jun 7, 2021
it has been removed.
xref: apache/apisix#4055

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
gxthrj pushed a commit to apache/apisix-ingress-controller that referenced this pull request Jun 8, 2021
it has been removed.
xref: apache/apisix#4055

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance the documentation of echo plugin

5 participants