fix: adjust the execution priority of request-id to fix opentelemetry has no request id#7281
fix: adjust the execution priority of request-id to fix opentelemetry has no request id#7281spacewander merged 7 commits intoapache:masterfrom
Conversation
apisix/plugins/opentelemetry.lua
Outdated
| local _M = { | ||
| version = 0.1, | ||
| priority = 12009, | ||
| priority = 11009, |
There was a problem hiding this comment.
I think it's not a good idea to set it adjacent to the request-id plugin. It's not extendable if we need to insert another plugin between them in the future.
There was a problem hiding this comment.
I think it's not a good idea to set it adjacent to the request-id plugin. It's not extendable if we need to insert another plugin between them in the future.
OK, already change to 11005
|
we also need to update the |
|
@jagerzhang Also, you need to check out the CI failures, we have some test cases to cover the plugin priority settings. |
|
@tokers |
Looks like this is the actual error: https://github.com/apache/apisix/runs/6977549863?check_suite_focus=true#step:15:700 |
|
@tokers I found that the order of plugins will verified in many places, like: Lines 44 to 89 in 69bb8b3 https://github.com/apache/apisix/blob/master/t/admin/plugins.t#L63-L131 https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L335-L410 I think it may be more convenient to uniformly abstract to one place, such as uniformly reading from |
|
@tokers |
… has no request id (#7281) Co-authored-by: Jagerzhang <jagerzhang@tencent.com>
… has no request id (apache#7281) Co-authored-by: Jagerzhang <jagerzhang@tencent.com>
… has no request id (#7281) Co-authored-by: Jagerzhang <jagerzhang@tencent.com>
… has no request id (apache#7281) Co-authored-by: Jagerzhang <jagerzhang@tencent.com>
Description
Adjust the execution priority of request-id from 11010 to 12015
Fixes #7239
Checklist