feat(kafka-logger): support sasl config in brokers by starsz · Pull Request #8050 · apache/apisix

starsz · 2022-10-09T05:51:21Z

Description

Thanks to @biubiue and the original PR #7782.

Checklist

I have explained the need for this PR and the problem it solves
I have explained the changes or the new features added to this PR
I have added tests corresponding to this change
I have updated the documentation to reflect this change
I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

biubiue · 2022-10-09T11:44:09Z

I think it is not good to put sasl_config under borkers node, if more than one borker node, you need to configure duplicate sasl_config

biubiue · 2022-10-09T11:45:04Z

I'm glad you continue this feat PR

starsz · 2022-10-10T01:52:58Z

I think it is not good to put sasl_config under borkers node, if more than one borker node, you need to configure duplicate sasl_config

Hi, @biubiue .I think we can put the sasl_config under brokers first so that we can support configuring different sasl_config under different brokers.

Then we can add sasl_config besides sasl_config as global sasl_config, if the broker doesn't configure sasl_config then it will use global sasl_config instead.

docs/en/latest/plugins/kafka-logger.md

docs/zh/latest/plugins/kafka-logger.md

spacewander · 2022-10-10T06:16:26Z

apisix/plugins/kafka-logger.lua

+                        properties = {
+                            mechanism = {
+                                type = "string",
+                                default = "PLAIN"


We can use enum to make sure the passing mechanism is legal? Although only PLAIN is currently supported.

Good suggestion. Let me add the enum and add a test case to cover it.

tzssangglass · 2022-10-10T06:28:52Z

LGTM

Co-authored-by: 罗泽轩 <spacewanderlzx@gmail.com>

soulbird · 2022-10-11T01:29:26Z

ci/pod/docker-compose.plugin.yml

+    volumes:
+      - ./ci/pod/kafka/kafka-server/kafka_jaas.conf:/opt/bitnami/kafka/config/kafka_jaas.conf:ro
+      - ./ci/pod/kafka/kafka-server/selfsigned.jks:/opt/bitnami/kafka/config/certs/kafka.keystore.jks:ro
+      - ./ci/pod/kafka/kafka-server/selfsigned.jks:/opt/bitnami/kafka/config/certs/kafka.truststore.jks:ro


The selfsigned.jks file is only generated when the last test is executed, look: https://github.com/apache/apisix/blob/master/.github/workflows/build.yml#L117-L120, and should not exist when the plugin test is executed. Why can CI still pass, very puzzled.....

Sorry.My fault.

Why can CI still pass, very puzzled....

The file or directory does not need to exist on the Docker host already. It is created on demand if it does not yet exist.
So it wouldn't influence the CI.

refer: https://docs.docker.com/storage/bind-mounts/

Co-authored-by: 罗泽轩 <spacewanderlzx@gmail.com> Co-authored-by: biubiue <hichuanbiao@gmail.com>

biubiue added 30 commits August 24, 2022 20:52

feat(kafka-logger): support sasl conf

40ddca3

feat(kafka-logger): doc add sasl conf

21be757

fix(kafka-logger): doc

fad3df6

feat(kafka-logger): test case

de82ec3

feat(kafka-logger): modify test case code style

33cd466

fix(kafka-logger): test case code style

7e1db99

fix(kafka-logger): test case code style

ebeebc8

fix(kafka-logger): test case code style

cd68da2

fix(kafka-logger): test case code style

0104c5a

Update kafka-logger.t

503011c

fix(kafka-logger): test case

18358aa

fix(kafka-logger): test case

3812c9c

Update kafka-logger.t

c8baf35

Update kafka-logger.t

d348987

Update kafka-logger.t

72f0d06

fix(kafka-logger): test case

5b7dd8c

fix(kafka-logger): try other actions

9f1817a

Update kafka-logger.t

588bb0f

Update kafka-logger.t

3a90b5d

Update kafka-logger.t

d10ea12

Update kafka-logger.t

70054aa

Update kafka-logger.t

35a581b

fix(kafka-logger): modify sasl_config properties

9d9f005

Update kafka-logger.md

8c41473

Update kafka-logger.t

4e1cc34

Update kafka-logger.lua

ddde433

Update kafka-logger.md

0444c00

Update kafka-logger.lua

cc90a47

fix(kafka-logger): test case

290070c

fix(kafka-logger): test case

1481240

biubiue and others added 5 commits September 27, 2022 10:12

test case

8ca60db

Merge branch 'master' into kafka_sasl

c68948f

fix: ci

82e81e6

fix: lint

1131842

fix: docker-compose

8612380

starsz added 2 commits October 10, 2022 10:20

doc: chinese doc

d8b59c2

doc: fix chinese doc

b6c4c6a

starsz marked this pull request as ready for review October 10, 2022 05:55

spacewander reviewed Oct 10, 2022

View reviewed changes

starsz and others added 5 commits October 10, 2022 14:33

Update docs/en/latest/plugins/kafka-logger.md

23dc1b1

Co-authored-by: 罗泽轩 <spacewanderlzx@gmail.com>

Update docs/en/latest/plugins/kafka-logger.md

1825dc8

Co-authored-by: 罗泽轩 <spacewanderlzx@gmail.com>

Update docs/zh/latest/plugins/kafka-logger.md

d0e53fd

Co-authored-by: 罗泽轩 <spacewanderlzx@gmail.com>

Update docs/zh/latest/plugins/kafka-logger.md

7cec61a

Co-authored-by: 罗泽轩 <spacewanderlzx@gmail.com>

chore: add enum for mechanism

8f08476

starsz requested review from soulbird, spacewander and tzssangglass October 10, 2022 07:49

tzssangglass previously approved these changes Oct 10, 2022

View reviewed changes

soulbird reviewed Oct 11, 2022

View reviewed changes

fix: docker compose

5d00e9a

starsz dismissed tzssangglass’s stale review via 5d00e9a October 11, 2022 01:58

soulbird approved these changes Oct 11, 2022

View reviewed changes

spacewander approved these changes Oct 11, 2022

View reviewed changes

spacewander merged commit c201d72 into apache:master Oct 11, 2022

starsz deleted the kafka_sasl branch October 11, 2022 05:45

Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022

feat(kafka-logger): support sasl config in brokers (apache#8050)

017c311

Co-authored-by: 罗泽轩 <spacewanderlzx@gmail.com> Co-authored-by: biubiue <hichuanbiao@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(kafka-logger): support sasl config in brokers#8050

feat(kafka-logger): support sasl config in brokers#8050
spacewander merged 45 commits intoapache:masterfrom
starsz:kafka_sasl

starsz commented Oct 9, 2022 •

edited

Loading

Uh oh!

biubiue commented Oct 9, 2022

Uh oh!

biubiue commented Oct 9, 2022

Uh oh!

starsz commented Oct 10, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

spacewander Oct 10, 2022

Uh oh!

starsz Oct 10, 2022

Uh oh!

tzssangglass commented Oct 10, 2022

Uh oh!

soulbird Oct 11, 2022

Uh oh!

starsz Oct 11, 2022

Uh oh!

soulbird Oct 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

starsz commented Oct 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

biubiue commented Oct 9, 2022

Uh oh!

biubiue commented Oct 9, 2022

Uh oh!

starsz commented Oct 10, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

spacewander Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

starsz Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

tzssangglass commented Oct 10, 2022

Uh oh!

soulbird Oct 11, 2022

Choose a reason for hiding this comment

Uh oh!

starsz Oct 11, 2022

Choose a reason for hiding this comment

Uh oh!

soulbird Oct 11, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

starsz commented Oct 9, 2022 •

edited

Loading