Merged
Conversation
Thanks for @tzssangglass to provide the inital implementation. Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
soulbird
approved these changes
Feb 28, 2023
bzp2010
approved these changes
Mar 1, 2023
| required = {"query"}, | ||
| } | ||
|
|
||
| local plugin_name = "degraphql" |
Contributor
There was a problem hiding this comment.
I have a small question, should we call it graphql-transcode according to the grpc class plugin specification (rest2grpc => grpc-transcode) 🤔
Member
Author
There was a problem hiding this comment.
We borrow the name degraphql from Kong. What do you think about it, @juzhiyuan?
Member
There was a problem hiding this comment.
From my understanding, de means decode, so degraphql means decode GraphQL. I think this name works because it does not belong to Kong only :)
Or graphql-transcode?
Member
Author
There was a problem hiding this comment.
IMHO, it would be better to keep the original name, so we don't need to modify this PR and other things which are not public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for @tzssangglass to provide the initial implementation.
Signed-off-by: spacewander spacewanderlzx@gmail.com
Description
Fixes #8787
Checklist