chore: replace golang.org/x/xerrors for stdlib errors (#763)

relates to:

- apache/arrow#5997
- apache/arrow#16992



The golang.org/x/xerrors module is a transitional module for what became
go1.13 errors. Most of its functionality is now available in stdlib
errors, with the exception of stdlib not providing a stack-trace (and
some utility functions related to that).

Looking at history to see if that functionality was essential for using
this package, I found that the golang.org/x/errors module was introduced
in [apache/arrow@7126fdb], to address [ARROW-7357].

> we should migrate away from `pkg/errors` to `golang.org/x/xerrors` to
> ensure better error handling (and one that is Go-1.13 compatible).

Based on the above, it looks like the intent was to provide
compatibility with go1.13+ errors, which are now mainline, so stdlib
errors should be preferred for this.

[ARROW-7357]: https://issues.apache.org/jira/browse/ARROW-7357
[apache/arrow@7126fdb]:
apache/arrow@7126fdb

### Rationale for this change


### What changes are included in this PR?


### Are these changes tested?


### Are there any user-facing changes?

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Co-authored-by: Matt Topol <zotthewizard@gmail.com>

Author: thaJeztah

arrow/cdata/cdata.go

@@ -54,7 +54,6 @@ import (
 	"github.com/apache/arrow-go/v18/arrow/array"
 	"github.com/apache/arrow-go/v18/arrow/bitutil"
 	"github.com/apache/arrow-go/v18/arrow/memory"
-	"golang.org/x/xerrors"
 )
 
 type (
@@ -224,22 +223,22 @@ func importSchema(schema *CArrowSchema) (ret arrow.Field, err error) {
 		var precision, scale int
 
 		if len(propList) < 2 || len(propList) > 3 {
-			return ret, xerrors.Errorf("invalid decimal spec '%s': wrong number of properties", f)
+			return ret, fmt.Errorf("invalid decimal spec '%s': wrong number of properties", f)
 		} else if len(propList) == 3 {
 			bitwidth, err = strconv.Atoi(propList[2])
 			if err != nil {
-				return ret, xerrors.Errorf("could not parse decimal bitwidth in '%s': %s", f, err.Error())
+				return ret, fmt.Errorf("could not parse decimal bitwidth in '%s': %w", f, err)
 			}
 		}
 
 		precision, err = strconv.Atoi(propList[0])
 		if err != nil {
-			return ret, xerrors.Errorf("could not parse decimal precision in '%s': %s", f, err.Error())
+			return ret, fmt.Errorf("could not parse decimal precision in '%s': %w", f, err)
 		}
 
 		scale, err = strconv.Atoi(propList[1])
 		if err != nil {
-			return ret, xerrors.Errorf("could not parse decimal scale in '%s': %s", f, err.Error())
+			return ret, fmt.Errorf("could not parse decimal scale in '%s': %w", f, err)
 		}
 
 		switch bitwidth {
@@ -252,7 +251,7 @@ func importSchema(schema *CArrowSchema) (ret arrow.Field, err error) {
 		case 256:
 			dt = &arrow.Decimal256Type{Precision: int32(precision), Scale: int32(scale)}
 		default:
-			return ret, xerrors.Errorf("unsupported decimal bitwidth, got '%s'", f)
+			return ret, fmt.Errorf("unsupported decimal bitwidth, got '%s'", f)
 		}
 	}
 
@@ -328,7 +327,7 @@ func importSchema(schema *CArrowSchema) (ret arrow.Field, err error) {
 
 	if dt == nil {
 		// if we didn't find a type, then it's something we haven't implemented.
-		err = xerrors.New("unimplemented type")
+		err = errors.New("unimplemented type")
 	} else {
 		ret.Type = dt
 	}
@@ -797,7 +796,7 @@ func (imp *cimporter) importFixedSizePrimitive() error {
 		values, err = imp.importFixedSizeBuffer(1, bitutil.BytesForBits(int64(fw.BitWidth())))
 	} else {
 		if fw.BitWidth() != 1 {
-			return xerrors.New("invalid bitwidth")
+			return errors.New("invalid bitwidth")
 		}
 		values, err = imp.importBitsBuffer(1)
 	}

arrow/cdata/interface.go

@@ -21,13 +21,13 @@ package cdata
 
 import (
 	"context"
+	"errors"
 	"unsafe"
 
 	"github.com/apache/arrow-go/v18/arrow"
 	"github.com/apache/arrow-go/v18/arrow/array"
 	"github.com/apache/arrow-go/v18/arrow/arrio"
 	"github.com/apache/arrow-go/v18/arrow/memory"
-	"golang.org/x/xerrors"
 )
 
 // SchemaFromPtr is a simple helper function to cast a uintptr to a *CArrowSchema
@@ -151,7 +151,7 @@ func ImportCRecordBatch(arr *CArrowArray, sc *CArrowSchema) (arrow.RecordBatch,
 	}
 
 	if field.Type.ID() != arrow.STRUCT {
-		return nil, xerrors.New("recordbatch array import must be of struct type")
+		return nil, errors.New("recordbatch array import must be of struct type")
 	}
 
 	return ImportCRecordBatchWithSchema(arr, arrow.NewSchema(field.Type.(*arrow.StructType).Fields(), &field.Metadata))

arrow/compute/utils.go

@@ -19,6 +19,7 @@
 package compute
 
 import (
+	"errors"
 	"fmt"
 	"io"
 	"time"
@@ -30,7 +31,6 @@ import (
 	"github.com/apache/arrow-go/v18/arrow/internal/debug"
 	"github.com/apache/arrow-go/v18/arrow/memory"
 	"github.com/apache/arrow-go/v18/internal/utils"
-	"golang.org/x/xerrors"
 )
 
 type bufferWriteSeeker struct {
@@ -84,7 +84,7 @@ func (b *bufferWriteSeeker) Seek(offset int64, whence int) (int64, error) {
 		newpos = b.buf.Len() + offs
 	}
 	if newpos < 0 {
-		return 0, xerrors.New("negative result pos")
+		return 0, errors.New("negative result pos")
 	}
 	b.pos = newpos
 	return int64(newpos), nil

arrow/datatype_fixedwidth.go

@@ -17,7 +17,8 @@
 package arrow
 
 import (
-	"cmp"
+  "cmp"
+	"errors"	
 	"fmt"
 	"strconv"
 	"sync"
@@ -26,7 +27,6 @@ import (
 	"github.com/apache/arrow-go/v18/arrow/decimal"
 	"github.com/apache/arrow-go/v18/arrow/internal/debug"
 	"github.com/apache/arrow-go/v18/internal/json"
-	"golang.org/x/xerrors"
 )
 
 type BooleanType struct{}
@@ -143,11 +143,11 @@ func TimestampFromStringInLocation(val string, unit TimeUnit, loc *time.Location
 	// more than nanosecond precision is provided
 	switch {
 	case unit == Second && lenWithoutZone > 19:
-		return 0, zoneFmt != "", xerrors.New("provided more than second precision for timestamp[s]")
+		return 0, zoneFmt != "", errors.New("provided more than second precision for timestamp[s]")
 	case unit == Millisecond && lenWithoutZone > 23:
-		return 0, zoneFmt != "", xerrors.New("provided more than millisecond precision for timestamp[ms]")
+		return 0, zoneFmt != "", errors.New("provided more than millisecond precision for timestamp[ms]")
 	case unit == Microsecond && lenWithoutZone > 26:
-		return 0, zoneFmt != "", xerrors.New("provided more than microsecond precision for timestamp[us]")
+		return 0, zoneFmt != "", errors.New("provided more than microsecond precision for timestamp[us]")
 	}
 
 	format += zoneFmt
@@ -220,14 +220,14 @@ func Time32FromString(val string, unit TimeUnit) (Time32, error) {
 	switch unit {
 	case Second:
 		if len(val) > 8 {
-			return 0, xerrors.New("cannot convert larger than second precision to time32s")
+			return 0, errors.New("cannot convert larger than second precision to time32s")
 		}
 	case Millisecond:
 		if len(val) > 12 {
-			return 0, xerrors.New("cannot convert larger than millisecond precision to time32ms")
+			return 0, errors.New("cannot convert larger than millisecond precision to time32ms")
 		}
 	case Microsecond, Nanosecond:
-		return 0, xerrors.New("time32 can only be seconds or milliseconds")
+		return 0, errors.New("time32 can only be seconds or milliseconds")
 	}
 
 	var (
@@ -275,10 +275,10 @@ func Time64FromString(val string, unit TimeUnit) (Time64, error) {
 	switch unit {
 	case Microsecond:
 		if len(val) > 15 {
-			return 0, xerrors.New("cannot convert larger than microsecond precision to time64us")
+			return 0, errors.New("cannot convert larger than microsecond precision to time64us")
 		}
 	case Second, Millisecond:
-		return 0, xerrors.New("time64 should only be microseconds or nanoseconds")
+		return 0, errors.New("time64 should only be microseconds or nanoseconds")
 	}
 
 	var (

arrow/internal/flight_integration/scenario.go

@@ -40,7 +40,6 @@ import (
 	"github.com/apache/arrow-go/v18/arrow/internal/arrjson"
 	"github.com/apache/arrow-go/v18/arrow/ipc"
 	"github.com/apache/arrow-go/v18/arrow/memory"
-	"golang.org/x/xerrors"
 	"google.golang.org/grpc"
 	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/status"
@@ -367,7 +366,7 @@ func CheckActionResults(ctx context.Context, client flight.Client, action *fligh
 
 	res, err := stream.Recv()
 	if res != nil || err != io.EOF {
-		return xerrors.New("action result stream had too many entries")
+		return errors.New("action result stream had too many entries")
 	}
 	return nil
 }
@@ -501,7 +500,7 @@ func (m *middlewareScenarioTester) RunClient(addr string, opts ...grpc.DialOptio
 	// this call is expected to fail
 	_, err = client.GetFlightInfo(ctx, &flight.FlightDescriptor{Type: flight.DescriptorCMD})
 	if err == nil {
-		return xerrors.New("expected call to fail")
+		return errors.New("expected call to fail")
 	}
 
 	if tm.received != "expected value" {

arrow/scalar/nested.go

@@ -25,7 +25,6 @@ import (
 	"github.com/apache/arrow-go/v18/arrow/array"
 	"github.com/apache/arrow-go/v18/arrow/internal/debug"
 	"github.com/apache/arrow-go/v18/arrow/memory"
-	"golang.org/x/xerrors"
 )
 
 type ListScalar interface {
@@ -331,7 +330,7 @@ func NewStructScalar(val []Scalar, typ arrow.DataType) *Struct {
 
 func NewStructScalarWithNames(val []Scalar, names []string) (*Struct, error) {
 	if len(val) != len(names) {
-		return nil, xerrors.New("mismatching number of field names and child scalars")
+		return nil, errors.New("mismatching number of field names and child scalars")
 	}
 
 	fields := make([]arrow.Field, len(names))

arrow/scalar/scalar.go

@@ -18,6 +18,7 @@ package scalar
 
 import (
 	"encoding/binary"
+	"errors"
 	"fmt"
 	"math"
 	"math/big"
@@ -37,7 +38,6 @@ import (
 	"github.com/apache/arrow-go/v18/arrow/float16"
 	"github.com/apache/arrow-go/v18/arrow/internal/debug"
 	"github.com/apache/arrow-go/v18/arrow/memory"
-	"golang.org/x/xerrors"
 )
 
 // Scalar represents a single value of a specific DataType as opposed to
@@ -97,7 +97,7 @@ func (s *scalar) IsValid() bool { return s.Valid }
 
 func (s *scalar) Validate() error {
 	if s.Type == nil {
-		return xerrors.New("scalar lacks a type")
+		return errors.New("scalar lacks a type")
 	}
 	return nil
 }
@@ -130,7 +130,7 @@ func (n *Null) Validate() (err error) {
 		return
 	}
 	if n.Valid {
-		err = xerrors.New("null scalar should have Valid = false")
+		err = errors.New("null scalar should have Valid = false")
 	}
 	return
 }

go.mod

@@ -47,7 +47,6 @@ require (
 	golang.org/x/exp v0.0.0-20260112195511-716be5621a96
 	golang.org/x/sync v0.20.0
 	golang.org/x/sys v0.43.0
-	golang.org/x/xerrors v0.0.0-20240903120638-7835f813f4da
 	gonum.org/v1/gonum v0.17.0
 	google.golang.org/grpc v1.80.0
 	google.golang.org/protobuf v1.36.11

go.sum

@@ -242,8 +242,6 @@ golang.org/x/tools v0.6.0/go.mod h1:Xwgl3UAJ/d3gWutnCtw505GrjyAbvKui8lOU390QaIU=
 golang.org/x/tools v0.43.0 h1:12BdW9CeB3Z+J/I/wj34VMl8X+fEXBxVR90JeMX5E7s=
 golang.org/x/tools v0.43.0/go.mod h1:uHkMso649BX2cZK6+RpuIPXS3ho2hZo4FVwfoy1vIk0=
 golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
-golang.org/x/xerrors v0.0.0-20240903120638-7835f813f4da h1:noIWHXmPHxILtqtCOPIhSt0ABwskkZKjD3bXGnZGpNY=
-golang.org/x/xerrors v0.0.0-20240903120638-7835f813f4da/go.mod h1:NDW/Ps6MPRej6fsCIbMTohpP40sJ/P/vI1MoTEGwX90=
 gonum.org/v1/gonum v0.17.0 h1:VbpOemQlsSMrYmn7T2OUvQ4dqxQXU+ouZFQsZOx50z4=
 gonum.org/v1/gonum v0.17.0/go.mod h1:El3tOrEuMpv2UdMrbNlKEh9vd86bmQ6vqIcDwxEOc1E=
 google.golang.org/genproto/googleapis/rpc v0.0.0-20260120221211-b8f7ae30c516 h1:sNrWoksmOyF5bvJUcnmbeAmQi8baNhqg5IWaI3llQqU=

internal/types/extension_types.go

@@ -19,12 +19,12 @@ package types
 
 import (
 	"encoding/binary"
+	"errors"
 	"fmt"
 	"reflect"
 
 	"github.com/apache/arrow-go/v18/arrow"
 	"github.com/apache/arrow-go/v18/arrow/array"
-	"golang.org/x/xerrors"
 )
 
 // Parametric1Array is a simple int32 array for use with the Parametric1Type
@@ -100,7 +100,7 @@ func (Parametric1Type) Deserialize(storage arrow.DataType, data string) (arrow.E
 	}
 
 	if storage.ID() != arrow.INT32 {
-		return nil, xerrors.New("parametric1type: must have int32 as underlying storage type")
+		return nil, errors.New("parametric1type: must have int32 as underlying storage type")
 	}
 
 	return &Parametric1Type{arrow.ExtensionBase{Storage: arrow.PrimitiveTypes.Int32}, int32(binary.LittleEndian.Uint32([]byte(data)))}, nil
@@ -155,7 +155,7 @@ func (Parametric2Type) Deserialize(storage arrow.DataType, data string) (arrow.E
 	}
 
 	if storage.ID() != arrow.INT32 {
-		return nil, xerrors.New("parametric1type: must have int32 as underlying storage type")
+		return nil, errors.New("parametric1type: must have int32 as underlying storage type")
 	}
 
 	return &Parametric2Type{arrow.ExtensionBase{Storage: arrow.PrimitiveTypes.Int32}, int32(binary.LittleEndian.Uint32([]byte(data)))}, nil
@@ -214,7 +214,7 @@ func (ExtStructType) Serialize() string { return "ext-struct-type-unique-code" }
 // returning the correct type if it matches "ext-struct-type-unique-code".
 func (ExtStructType) Deserialize(_ arrow.DataType, serialized string) (arrow.ExtensionType, error) {
 	if string(serialized) != "ext-struct-type-unique-code" {
-		return nil, xerrors.New("type identifier did not match")
+		return nil, errors.New("type identifier did not match")
 	}
 	return NewExtStructType(), nil
 }