Skip to content

ARROW-7357: [Go] migrate to x/xerrors#5997

Closed
sbinet wants to merge 1 commit intoapache:masterfrom
sbinet-gonum:issue-7357
Closed

ARROW-7357: [Go] migrate to x/xerrors#5997
sbinet wants to merge 1 commit intoapache:masterfrom
sbinet-gonum:issue-7357

Conversation

@sbinet
Copy link
Copy Markdown
Contributor

@sbinet sbinet commented Dec 9, 2019

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 9, 2019

@sbinet sbinet closed this in 7126fdb Dec 9, 2019
@sbinet sbinet deleted the issue-7357 branch December 9, 2019 16:36
zeroshade added a commit to apache/arrow-go that referenced this pull request Apr 13, 2026
relates to:

- apache/arrow#5997
- apache/arrow#16992



The golang.org/x/xerrors module is a transitional module for what became
go1.13 errors. Most of its functionality is now available in stdlib
errors, with the exception of stdlib not providing a stack-trace (and
some utility functions related to that).

Looking at history to see if that functionality was essential for using
this package, I found that the golang.org/x/errors module was introduced
in [apache/arrow@7126fdb], to address [ARROW-7357].

> we should migrate away from `pkg/errors` to `golang.org/x/xerrors` to
> ensure better error handling (and one that is Go-1.13 compatible).

Based on the above, it looks like the intent was to provide
compatibility with go1.13+ errors, which are now mainline, so stdlib
errors should be preferred for this.

[ARROW-7357]: https://issues.apache.org/jira/browse/ARROW-7357
[apache/arrow@7126fdb]:
apache/arrow@7126fdb

### Rationale for this change


### What changes are included in this PR?


### Are these changes tested?


### Are there any user-facing changes?

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Co-authored-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant