cdata interface with bazel + gazelle requires patches to build

[notfilippo]

Describe the bug, including details regarding any error messages, version, and platform.

After the recent upgrades to v18.1 I have noticed some issues in my bazel + gazelle build system, which I think are related:

I'm getting

Undefined symbols for architecture arm64:
  "_ArrowArrayIsReleased", referenced from:
      __cgo_a6f56f66f2c3_Cfunc_ArrowArrayIsReleased in 000049.o
  "_ArrowArrayMarkReleased", referenced from:
      __cgo_a6f56f66f2c3_Cfunc_ArrowArrayMarkReleased in 000051.o
  "_ArrowArrayMove", referenced from:
      __cgo_a6f56f66f2c3_Cfunc_ArrowArrayMove in 000049.o
  "_ArrowArrayRelease", referenced from:
      __cgo_a6f56f66f2c3_Cfunc_ArrowArrayRelease in 000049.o
  "_ArrowArrayStreamMove", referenced from:
      __cgo_a6f56f66f2c3_Cfunc_ArrowArrayStreamMove in 000049.o
  "_ArrowArrayStreamRelease", referenced from:
      __cgo_a6f56f66f2c3_Cfunc_ArrowArrayStreamRelease in 000049.o
  "_ArrowSchemaIsReleased", referenced from:
      __cgo_a6f56f66f2c3_Cfunc_ArrowSchemaIsReleased in 000052.o
  "_ArrowSchemaMarkReleased", referenced from:
      __cgo_a6f56f66f2c3_Cfunc_ArrowSchemaMarkReleased in 000052.o
  "_ArrowSchemaRelease", referenced from:
      __cgo_a6f56f66f2c3_Cfunc_ArrowSchemaRelease in 000049.o
ld: symbol(s) not found for architecture arm64

Which I presume is due to the removal of the static qualifier in the function defined helpers.h.

Would it be acceptable to introduce a helpers.c with the function definitions?

Component(s)

Other

[notfilippo]

I just saw that the library was upgraded recently with a reintroduction of the static qualifiers. Thanks for that. Would we be still interested in moving the implementation in a separate C file instead of keeping the bodies in the header?

[zeroshade]

Any particular reason to move the implementations as opposed to keeping them in the header (for inlining and for ease of updating to keep in sync with Arrow C++)?

[notfilippo]

Actually, I just checked and the move of the headers from their separate folder to the folder of the cdata module makes gazelle realize that those .h files should be included in the module build definition, so the compilation succeeds. No point in doing the change then. Thanks!