Skip to content

Fix: Handle null values in PlainFixedLenByteArrayEncoder gracefully #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeroshade merged 3 commits into from
Mar 24, 2025
Merged

Fix: Handle null values in PlainFixedLenByteArrayEncoder gracefully #320

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0752be3
fix: (GH-#71) Handle null values in PlainFixedLenByteArrayEncoder
singh1203 Mar 20, 2025
bf3fe1d
fix: Add test for FixedLenByteArrayEncoder
singh1203 Mar 24, 2025
915d724
Merge branch 'apache:main' into ByteArrayEncoder
singh1203 Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions parquet/internal/encoding/fixed_len_byte_array_encoder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,15 @@ func (enc *PlainFixedLenByteArrayEncoder) Put(in []parquet.FixedLenByteArray) {

bytesNeeded := len(in) * typeLen
enc.sink.Reserve(bytesNeeded)

emptyValue := make([]byte, typeLen)

for _, val := range in {
if val == nil {
panic("value cannot be nil")
enc.sink.UnsafeWrite(emptyValue)
} else {
enc.sink.UnsafeWrite(val[:typeLen])
}
enc.sink.UnsafeWrite(val[:typeLen])
}
}

Expand Down
Loading
⚡