-
Notifications
You must be signed in to change notification settings - Fork 111
feat: expose Payload.WritePayload to allow serializing into IPC format #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zeroshade
merged 7 commits into
apache:main
from
alvarowolfx:feat-schemaless-ipc-writer
Jun 25, 2025
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c75de09
feat: add option for ipc.writer to skip writing schema
alvarowolfx 72e883d
fix: emitSchema should default to true
alvarowolfx d8ae0e2
test: add test for schemaless ipc writer
alvarowolfx 3664d9f
fix: invert flag meaning
alvarowolfx 7243940
feat: add NewRecordBatchWriter
alvarowolfx 941e648
feat: expose WritePayload func
alvarowolfx 5af61c2
fix: remove flags to skip emit schema
alvarowolfx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -91,8 +91,9 @@ type Writer struct { | |
|
|
||
| // map of the last written dictionaries by id | ||
| // so we can avoid writing the same dictionary over and over | ||
| lastWrittenDicts map[int64]arrow.Array | ||
| emitDictDeltas bool | ||
| lastWrittenDicts map[int64]arrow.Array | ||
| emitDictDeltas bool | ||
| skipEmittingSchema bool | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above, can we revert the changes for |
||
| } | ||
|
|
||
| // NewWriterWithPayloadWriter constructs a writer with the provided payload writer | ||
|
|
@@ -116,14 +117,15 @@ func NewWriterWithPayloadWriter(pw PayloadWriter, opts ...Option) *Writer { | |
| func NewWriter(w io.Writer, opts ...Option) *Writer { | ||
| cfg := newConfig(opts...) | ||
| return &Writer{ | ||
| w: w, | ||
| mem: cfg.alloc, | ||
| pw: &streamWriter{w: w}, | ||
| schema: cfg.schema, | ||
| codec: cfg.codec, | ||
| emitDictDeltas: cfg.emitDictDeltas, | ||
| compressNP: cfg.compressNP, | ||
| compressors: make([]compressor, cfg.compressNP), | ||
| w: w, | ||
| mem: cfg.alloc, | ||
| pw: &streamWriter{w: w}, | ||
| schema: cfg.schema, | ||
| codec: cfg.codec, | ||
| emitDictDeltas: cfg.emitDictDeltas, | ||
| skipEmittingSchema: cfg.skipEmittingSchema, | ||
| compressNP: cfg.compressNP, | ||
| compressors: make([]compressor, cfg.compressNP), | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -276,6 +278,11 @@ func (w *Writer) start() error { | |
| w.mapper.ImportSchema(w.schema) | ||
| w.lastWrittenDicts = make(map[int64]arrow.Array) | ||
|
|
||
| // skip writing schema payloads | ||
| if w.skipEmittingSchema { | ||
| return nil | ||
| } | ||
|
|
||
| // write out schema payloads | ||
| ps := payloadFromSchema(w.schema, w.mem, &w.mapper) | ||
| defer ps.Release() | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove this?