feat: add append_buffer for NullBufferBuilder#7308
Merged
alamb merged 2 commits intoapache:mainfrom Mar 19, 2025
Merged
Conversation
alamb
reviewed
Mar 18, 2025
| if buffer.null_count() > 0 { | ||
| self.materialize_if_needed(); | ||
| } | ||
| if let Some(buf) = self.bitmap_builder.as_mut() { |
Contributor
There was a problem hiding this comment.
If there are no nulls in self (so not materalized) and a buffer with nulls is pushed, won't this code ignore those nulls 🤔
Member
Author
There was a problem hiding this comment.
No, as it's the same code as the slice
Contributor
There was a problem hiding this comment.
I believe this should be covered by the line above that calls materialize_if_needed
tustvold
approved these changes
Mar 18, 2025
| if buffer.null_count() > 0 { | ||
| self.materialize_if_needed(); | ||
| } | ||
| if let Some(buf) = self.bitmap_builder.as_mut() { |
Contributor
There was a problem hiding this comment.
I believe this should be covered by the line above that calls materialize_if_needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Allow for better performance when concatenating null buffer
What changes are included in this PR?
Added
append_bufferfunction in theNullBufferBuilderthat just call the underlyingBooleanBufferBuilderAre there any user-facing changes?
yes, new API