Merged
Conversation
Contributor
|
Thanks @jhorstmann -- I am running the write benchmarks on this PR to see if there is any performance impact |
Contributor
|
I'll take a look soon. I had no idea this wasn't supported 😅. Sounds like something to add to the implementation status page. |
Contributor
|
My benchmark results show no significant change in performance |
etseidl
approved these changes
Apr 1, 2025
Contributor
etseidl
left a comment
There was a problem hiding this comment.
Looks good. Thanks @jhorstmann for noticing this was missing!
Contributor
|
I merged up from main to resolve some merge conflicts |
Contributor
|
Merged to get clippy fixes for new Clippy version |
Contributor
|
🚀 we have a clean CI run Thanks again @jhorstmann and @etseidl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
encoding_statsin Parquet Writing #7341.Rationale for this change
PageEncodingStatscan be useful to determine up front whether all pages of a column are dictionary encoded. Keeping track of the counts per page type and encoding is also quite cheap, and their metadata size is small, so they can be enabled always independent of theEnabledStatisticssetting.What changes are included in this PR?
Are there any user-facing changes?
No api changes, written files will now include
PageEncodingStatswhich previously were alwaysNone.