feat: add method for sync Parquet reader read bloom filter#8024
Merged
alamb merged 2 commits intoapache:mainfrom Aug 1, 2025
Merged
feat: add method for sync Parquet reader read bloom filter#8024alamb merged 2 commits intoapache:mainfrom
alamb merged 2 commits intoapache:mainfrom
Conversation
Member
Author
|
@alamb would you mind take a look? (or just close this). I use this in a poc, might switch to async_reader when I goto production version |
alamb
approved these changes
Jul 31, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @mapleFU -- I think this code looks good to me and it provides parity with the async reader.
As I mentioned on #8023 (comment), I have a plan / idea of how to avoid having to implement features twice for two different I/O models, but it isn't quite done yet (and even so this API is still nice to have)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Add sync parquet read bloom filter.
What changes are included in this PR?
Add a sync
get_row_group_column_bloom_filterAre these changes tested?
By unittests
Are there any user-facing changes?
Api added