[Variant] Rename ValueBuffer as ValueBuilder#8187
Merged
alamb merged 2 commits intoapache:mainfrom Aug 20, 2025
Merged
Conversation
Contributor
|
I plan to merge this one in as soon as the CI passes, as I think it is likely to accumulate conflicts |
Contributor
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ValueBufferasValueBuilder#8186Rationale for this change
The class has always built variant values (metadata being handled separately), so rename it
ValueBuilderto be more self-documenting.What changes are included in this PR?
Class renamed, along with all methods, local variables and documentation that reference it.
Are these changes tested?
It's a rename. If it compiles it's correct.
Are there any user-facing changes?
No.