Skip to content

Sort: Change lexsort comment from stable to unstable#8245

Merged
mbrobbel merged 3 commits intoapache:mainfrom
mapleFU:fix-sort-comment
Aug 29, 2025
Merged

Sort: Change lexsort comment from stable to unstable#8245
mbrobbel merged 3 commits intoapache:mainfrom
mapleFU:fix-sort-comment

Conversation

@mapleFU
Copy link
Copy Markdown
Member

@mapleFU mapleFU commented Aug 29, 2025

Which issue does this PR close?

The doc for lexsort says it's stable. However, it's an unstable sort.

Rationale for this change

Fix the document.

What changes are included in this PR?

Fix the document.

Are these changes tested?

No need

Are there any user-facing changes?

Doc change

@mapleFU mapleFU requested a review from alamb August 29, 2025 01:32
@github-actions github-actions Bot added the arrow Changes to the arrow crate label Aug 29, 2025
Copy link
Copy Markdown
Member

@mbrobbel mbrobbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can rebase/merge main to fix CI.

Comment thread arrow-ord/src/sort.rs Outdated
mapleFU and others added 2 commits August 29, 2025 18:44
Co-authored-by: Matthijs Brobbel <m1brobbel@gmail.com>
@mbrobbel mbrobbel merged commit 3dcd23f into apache:main Aug 29, 2025
17 checks passed
@mbrobbel
Copy link
Copy Markdown
Member

Thanks @mapleFU

@mapleFU mapleFU deleted the fix-sort-comment branch August 29, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants