Skip to content

feat: hyperbolic trig functions#2784

Merged
mbutrovich merged 3 commits intoapache:mainfrom
psvri:feat_hyperbolic
Nov 19, 2025
Merged

feat: hyperbolic trig functions#2784
mbutrovich merged 3 commits intoapache:mainfrom
psvri:feat_hyperbolic

Conversation

@psvri
Copy link
Copy Markdown
Contributor

@psvri psvri commented Nov 14, 2025

Which issue does this PR close?

Partially implements #240

Rationale for this change

Add support for hyperbolic spark functions cosh, sinh, tanh

What changes are included in this PR?

How are these changes tested?

UT tests

@mbutrovich
Copy link
Copy Markdown
Contributor

Does these have ANSI and non-ANSI behavior differences in Spark (e.g., exception vs. NULLs)?

@mbutrovich mbutrovich changed the title Feat hyperbolic feat: hyperbolic trig functions Nov 14, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.27%. Comparing base (f09f8af) to head (eccff50).
⚠️ Report is 703 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2784      +/-   ##
============================================
+ Coverage     56.12%   58.27%   +2.15%     
- Complexity      976     1421     +445     
============================================
  Files           119      157      +38     
  Lines         11743    14110    +2367     
  Branches       2251     2361     +110     
============================================
+ Hits           6591     8223    +1632     
- Misses         4012     4701     +689     
- Partials       1140     1186      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@martin-g martin-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can also add support for asinh, acosh and atanh with this PR ?!

@psvri
Copy link
Copy Markdown
Contributor Author

psvri commented Nov 18, 2025

Does these have ANSI and non-ANSI behavior differences in Spark (e.g., exception vs. NULLs)?

Based on my understanding I think there is no special ANSI handling as in the docs, I dont see a mention of ANSI behavior . Also in the sparks codegen , its just calling the math function directly.

@psvri
Copy link
Copy Markdown
Contributor Author

psvri commented Nov 18, 2025

Maybe you can also add support for asinh, acosh and atanh with this PR ?!

Can I do it in another PR if its okay ?

@martin-g
Copy link
Copy Markdown
Member

Can I do it in another PR if its okay ?

Of course!

Copy link
Copy Markdown
Contributor

@mbutrovich mbutrovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing tests are fairly limited, we should have something that uses CometFuzzTestBase for these sorts of functions, but that's maybe beyond the scope of this PR. The changes look good to me. Thanks @psvri!

@mbutrovich mbutrovich merged commit 82df9e7 into apache:main Nov 19, 2025
154 of 156 checks passed
mbutrovich added a commit to mbutrovich/datafusion-comet that referenced this pull request Nov 19, 2025
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants