feat: hyperbolic trig functions#2784
Conversation
|
Does these have ANSI and non-ANSI behavior differences in Spark (e.g., exception vs. NULLs)? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2784 +/- ##
============================================
+ Coverage 56.12% 58.27% +2.15%
- Complexity 976 1421 +445
============================================
Files 119 157 +38
Lines 11743 14110 +2367
Branches 2251 2361 +110
============================================
+ Hits 6591 8223 +1632
- Misses 4012 4701 +689
- Partials 1140 1186 +46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
martin-g
left a comment
There was a problem hiding this comment.
Maybe you can also add support for asinh, acosh and atanh with this PR ?!
Can I do it in another PR if its okay ? |
Of course! |
mbutrovich
left a comment
There was a problem hiding this comment.
The existing tests are fairly limited, we should have something that uses CometFuzzTestBase for these sorts of functions, but that's maybe beyond the scope of this PR. The changes look good to me. Thanks @psvri!
Which issue does this PR close?
Partially implements #240
Rationale for this change
Add support for hyperbolic spark functions
cosh,sinh,tanhWhat changes are included in this PR?
How are these changes tested?
UT tests