chore: Migrate concat tests to sql based testing framework#3352
Merged
mbutrovich merged 1 commit intoapache:mainfrom Feb 1, 2026
Merged
chore: Migrate concat tests to sql based testing framework#3352mbutrovich merged 1 commit intoapache:mainfrom
concat tests to sql based testing framework#3352mbutrovich merged 1 commit intoapache:mainfrom
Conversation
Member
Author
|
@mbutrovich Since you asked about this, here is an example PR to migrate existing tests to the new framework. The PR is net negative, which I know you like 😄 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3352 +/- ##
============================================
+ Coverage 56.12% 60.00% +3.87%
- Complexity 976 1475 +499
============================================
Files 119 175 +56
Lines 11743 16165 +4422
Branches 2251 2681 +430
============================================
+ Hits 6591 9699 +3108
- Misses 4012 5114 +1102
- Partials 1140 1352 +212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
force-pushed
the
chore/migrate-concat-tests-to-sql
branch
4 times, most recently
from
0768bba to
ca7621e
Compare
…ework Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
andygrove
force-pushed
the
chore/migrate-concat-tests-to-sql
branch
from
ca7621e to
1cc3ce1
Compare
mbutrovich
approved these changes
Feb 1, 2026
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
LGTM, thanks @andygrove!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
concat.sqlconcat.sqlusingexpect_fallbackCometExpressionSuite(concat strings, arrays, binary) andCometStringExpressionSuite(concat_ws)Test plan
mvn test -pl spark -Dsuites=org.apache.comet.CometSqlFileTestSuite -Dcomet.test.file=concat— all 260 tests pass🤖 Generated with Claude Code