Skip to content

chore: 4.5x reduction in number of golden files#3399

Merged
andygrove merged 5 commits intoapache:mainfrom
andygrove:fewer-golden-files
Feb 6, 2026
Merged

chore: 4.5x reduction in number of golden files#3399
andygrove merged 5 commits intoapache:mainfrom
andygrove:fewer-golden-files

Conversation

@andygrove
Copy link
Copy Markdown
Member

@andygrove andygrove commented Feb 5, 2026

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

  • only generate golden files for the native_datafusion and native_iceberg_compat scans, dropping auto
  • only generate extended explain plan - drop simplified and regular explain plan

How are these changes tested?

@kazuyukitanimura
Copy link
Copy Markdown
Contributor

So auto == native_iceberg_compat IIUC
Will this cause to slip some bugs in the future?

@andygrove
Copy link
Copy Markdown
Member Author

So auto == native_iceberg_compat IIUC Will this cause to slip some bugs in the future?

Correct, auto is currently the same as native_iceberg_compat. The main change with this PR is that we no longer test with native_datafusion, so it is possible that we could introduce changes that mean we fall back to Spark for some operator when native_datafusion is enabled and not notice that.

However, the plan is for auto mode to eventually choose between native_datafusion and native_iceberg_compat, so we would catch any regressions once this happens.

Note that the worst case scenario here is not missing any kind of correctness issue. This test suite does not run any queries. It just checks that the plan is expected.

@andygrove andygrove marked this pull request as ready for review February 5, 2026 15:20
@comphead
Copy link
Copy Markdown
Contributor

comphead commented Feb 5, 2026

The main change with this PR is that we no longer test with native_datafusion

I'm prob not getting this. native_datafusion is supported, why not longer test? 🤔

@andygrove andygrove changed the title chore: 9x reduction in number of golden files chore: 4.5x reduction in number of golden files Feb 6, 2026
@andygrove
Copy link
Copy Markdown
Member Author

Alright, let's try a different approach. Let's generate golden files for the two scan implementations native_datafusion and native_iceberg_compat, and not for auto since that will always pick from these two.

Copy link
Copy Markdown
Contributor

@mbutrovich mbutrovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintaining two sets, one for each parquet scan, makes sense to me. Thanks @andygrove!

@andygrove andygrove merged commit 9b05dfe into apache:main Feb 6, 2026
111 checks passed
@andygrove andygrove deleted the fewer-golden-files branch February 6, 2026 20:26
@andygrove
Copy link
Copy Markdown
Member Author

Thanks for the good feedback @kazuyukitanimura @comphead @mbutrovich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants