feat(serde): introduce structured SupportCondition for expression support-level metadata#4052
Closed
andygrove wants to merge 10 commits intoapache:mainfrom
Closed
feat(serde): introduce structured SupportCondition for expression support-level metadata#4052andygrove wants to merge 10 commits intoapache:mainfrom
andygrove wants to merge 10 commits intoapache:mainfrom
Conversation
…ind and SupportLevel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4050.
Rationale for this change
Issue #4050 asks for a single source of truth for Spark expression compatibility that can drive doc generation and cross-version audits. This PR lays the data-model foundation: a structured
SupportConditiontype whose instances are enumerable at build time. Free-formgetSupportLevelrequire manual effort to keep in sync with documentation.What changes are included in this PR?
SupportCondition[-T <: Expression]trait +SupportLevelKindsum type inSupportLevel.scala, with builder helpers (apply,unsupported,incompatible,compatibleWithNote).CometExpressionSerde[T]gainsconditions: Seq[SupportCondition[T]]. DefaultgetSupportLevelis derived from it (first-match-wins, falls back toCompatible(None)).getSupportLevelcontinue to work unchanged.CometLength(single condition) andCometSortArray(two ordered conditions, one config-dependent).Deferred to follow-up PRs: backfilling remaining serdes, aggregation across serde registry, doc generation, CI consistency checks, Spark-version metadata on conditions.
How are these changes tested?
New
SupportConditionSuitewith 12 unit tests covering: empty conditions, no match, first-match ordering, eachSupportLevelKind, expression-dependent messages, and per-serde assertions forCometLengthandCometSortArray(id / level / description). ExistingCometStringExpressionSuiteandCometArrayExpressionSuitepass unchanged, confirming observable behavior is preserved.