chore: fix clippy error in ci#803
Merged
alamb merged 2 commits intoapache:mainfrom Feb 17, 2023
Merged
Conversation
Pull Request Test Coverage Report for Build 4081311050
💛 - Coveralls |
91e0165 to
b6a8af1
Compare
Contributor
Author
|
I fixed this but it also might be good simply disable this rule. |
AugustoFKL
approved these changes
Feb 15, 2023
Contributor
AugustoFKL
left a comment
There was a problem hiding this comment.
Well, only linter fixes
Thanks!
Contributor
|
@alamb, can this be approved before other PRs, please? It seems like Rust had an update, so other PR's linters are failing. |
alamb
approved these changes
Feb 17, 2023
Contributor
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @togami2864 and @AugustoFKL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid clippy error like #802 in CI.
Maybe this ci error has affected by rust-lang/rust-clippy#10265