Skip to content

Add test for LIKE newline handling#10160

Merged
alamb merged 1 commit intoapache:mainfrom
Jefffrey:like-newline-test
Apr 21, 2024
Merged

Add test for LIKE newline handling#10160
alamb merged 1 commit intoapache:mainfrom
Jefffrey:like-newline-test

Conversation

@Jefffrey
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #1915

Rationale for this change

Issue seems resolved, adding a test to lock this in.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Apr 21, 2024
Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice -- thank you @Jefffrey

I also double checked that \n was properly handled in datafusion

> select 'foo\nbar', 'foo';
+-----------+-------------+
| Utf8("foo | Utf8("foo") |
| bar")     |             |
+-----------+-------------+
| foo       | foo         |
| bar       |             |
+-----------+-------------+
1 row(s) fetched.
Elapsed 0.001 seconds.

@alamb alamb merged commit 6f5d6a2 into apache:main Apr 21, 2024
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Apr 21, 2024

(thank you for cleaning up old issues as well 🙏 )

@Jefffrey Jefffrey deleted the like-newline-test branch April 21, 2024 11:27
ccciudatu pushed a commit to hstack/datafusion that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LIKE operator incorrectly handles newlines

2 participants